Skip to content

Conversation

BigBlackWolf
Copy link
Contributor

@BigBlackWolf BigBlackWolf commented Sep 19, 2024

Description

Base sample on python GoogleCloudPlatform/python-docs-samples#12598

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 19, 2024
@BigBlackWolf BigBlackWolf force-pushed the feat_generativeaionvertexai_gemma2_predict_gpu branch from 570c1a9 to 7e86d0e Compare September 19, 2024 12:57
@BigBlackWolf BigBlackWolf added kokoro:run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 19, 2024
@BigBlackWolf BigBlackWolf marked this pull request as ready for review September 19, 2024 13:44
@BigBlackWolf BigBlackWolf requested review from a team as code owners September 19, 2024 13:44
Copy link

snippet-bot bot commented Sep 19, 2024

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@BigBlackWolf BigBlackWolf force-pushed the feat_generativeaionvertexai_gemma2_predict_gpu branch from 7e86d0e to 216227f Compare September 23, 2024 09:31
"google.golang.org/protobuf/types/known/structpb"
)

type ClientInterface interface {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before moving forward with this PR, we need to figure out a way to not include the interface in the sample - it's used only for testing purposes and shouldn't overcomplicate the sample code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved interface under the sample, out of the region tag. Additionally, described the way of initializing and closing real one in comment to the function.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@telpirion WDYT? Can we merge or would recommend additional changes?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rewritten this sample to more closely match samples style. I'll approve and merge shortly.

@BigBlackWolf BigBlackWolf requested a review from a team as a code owner September 24, 2024 17:47
@BigBlackWolf BigBlackWolf force-pushed the feat_generativeaionvertexai_gemma2_predict_gpu branch from 6c42138 to 9f7d7cd Compare September 24, 2024 18:06
@telpirion telpirion dismissed rsamborski’s stale review October 7, 2024 18:44

Approving and merging sample

@BigBlackWolf BigBlackWolf merged commit 8957a58 into main Oct 7, 2024
9 checks passed
@BigBlackWolf BigBlackWolf deleted the feat_generativeaionvertexai_gemma2_predict_gpu branch October 7, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants