-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: gemma2 samples with accelerated TPU and GPU #4395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: gemma2 samples with accelerated TPU and GPU #4395
Conversation
570c1a9
to
7e86d0e
Compare
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
7e86d0e
to
216227f
Compare
gemma2/gemma2_predict_gpu.go
Outdated
"google.golang.org/protobuf/types/known/structpb" | ||
) | ||
|
||
type ClientInterface interface { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before moving forward with this PR, we need to figure out a way to not include the interface in the sample - it's used only for testing purposes and shouldn't overcomplicate the sample code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved interface under the sample, out of the region tag. Additionally, described the way of initializing and closing real one in comment to the function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@telpirion WDYT? Can we merge or would recommend additional changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've rewritten this sample to more closely match samples style. I'll approve and merge shortly.
6c42138
to
9f7d7cd
Compare
Description
Base sample on python GoogleCloudPlatform/python-docs-samples#12598
Checklist
go test -v ./..
(see Testing)gofmt
(see Formatting)go vet
(see Formatting)