-
Notifications
You must be signed in to change notification settings - Fork 1.8k
test(spanner): Add integration test to check that requests with large message sizes that are under the limit succeed #5392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…that are under the limit succeed
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @kinsaurralde, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new integration test for Google Cloud Spanner to validate the successful handling of transactions involving large message sizes, specifically those that remain within the 100MB mutation limit. The test leverages a newly added sample function that generates and inserts substantial data into a Spanner database, ensuring the system's robustness and correct behavior under such conditions. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds an integration test to verify that Spanner requests with large message sizes under the API limit can be successfully processed. A new sample function, writeLargeData
, is introduced for this purpose, along with a corresponding test, TestTxWithLargeMessageSize
. The overall approach is sound and adds valuable test coverage. I have a few suggestions for the new spanner_insert_large_data.go
file to improve code quality and adhere to Go best practices.
* Remove redunant ctx initialization * Fix comment typo * Replace "math/rand" with "crypto/rand"
@codyoss Can you please check this? |
Description
Checklist
go test -v ./..
(see Testing)gofmt
(see Formatting)go vet
(see Formatting)