Skip to content

Conversation

kinsaurralde
Copy link

Description

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@kinsaurralde kinsaurralde requested review from a team as code owners October 1, 2025 23:07
Copy link

snippet-bot bot commented Oct 1, 2025

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples. labels Oct 1, 2025
Copy link
Contributor

Summary of Changes

Hello @kinsaurralde, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new integration test for Google Cloud Spanner to validate the successful handling of transactions involving large message sizes, specifically those that remain within the 100MB mutation limit. The test leverages a newly added sample function that generates and inserts substantial data into a Spanner database, ensuring the system's robustness and correct behavior under such conditions.

Highlights

  • New Integration Test: Added TestTxWithLargeMessageSize to verify that Spanner transactions with large message sizes (under the 100MB limit) succeed.
  • New Sample Function: Introduced writeLargeData function in a new file, spanner_insert_large_data.go, which demonstrates inserting multiple rows with a 10MB byte slice each, totaling a large data insertion within Spanner's mutation limits.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds an integration test to verify that Spanner requests with large message sizes under the API limit can be successfully processed. A new sample function, writeLargeData, is introduced for this purpose, along with a corresponding test, TestTxWithLargeMessageSize. The overall approach is sound and adds valuable test coverage. I have a few suggestions for the new spanner_insert_large_data.go file to improve code quality and adhere to Go best practices.

* Remove redunant ctx initialization
* Fix comment typo
* Replace "math/rand" with "crypto/rand"
@sakthivelmanii
Copy link

@codyoss Can you please check this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants