Skip to content

Conversation

lvoelz
Copy link

@lvoelz lvoelz commented Oct 8, 2025

Update create_note.go to use attestations instead of vulnerabilities, in line with go/aa-deprecate-3p-metadata.

Update create_note.go to use attestations instead of vulnerabilities, in line with go/aa-deprecate-3p-metadata.
@lvoelz lvoelz requested review from a team as code owners October 8, 2025 18:01
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 8, 2025
Copy link
Contributor

Summary of Changes

Hello @lvoelz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This PR refactors the create_note.go file to use attestations instead of vulnerabilities, aligning with an internal deprecation guideline. The change involves updating the grafeaspb.Note type from Note_Vulnerability to Note_Attestation and adjusting the note's content accordingly.

Highlights

  • Intent: This pull request updates create_note.go to switch from using 'vulnerabilities' to 'attestations' when creating notes. This change aligns with the deprecation of third-party metadata as described in go/aa-deprecate-3p-metadata.
  • Changes: The primary change is in container_registry/container_analysis/create_note.go. The createNote function's grafeaspb.Note type definition has been modified. Specifically, the Type field now uses Note_Attestation instead of Note_Vulnerability, and the associated VulnerabilityNote structure has been replaced with an AttestationNote containing a Hint with a HumanReadableName.
  • Reviewer Activity: No reviewer activity has been recorded yet for this pull request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

@briandorsey
Copy link
Member

Thanks for the updates!

It looks like there are some small consistency updates needed:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants