Skip to content

Conversation

cfloress
Copy link
Contributor

@cfloress cfloress commented Oct 10, 2025

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@cfloress cfloress requested review from a team as code owners October 10, 2025 21:45
Copy link

snippet-bot bot commented Oct 10, 2025

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 10, 2025
Copy link
Contributor

Summary of Changes

Hello @cfloress, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the genai Go samples by introducing three new examples that demonstrate advanced capabilities of the Gemini model. These include live grounding with Google Search for more accurate and up-to-date responses, live function calling to enable model interaction with external tools, and structured output generation for parsing model responses into predictable JSON formats. These additions provide valuable resources for developers looking to leverage the full potential of the GenAI SDK.

Highlights

  • Live Grounding with Google Search: New sample demonstrating how to use the Gemini model with Google Search for grounded responses, enhancing the model's ability to provide accurate and up-to-date information.
  • Live Function Calling: New sample showcasing live function calls with text input, allowing the Gemini model to interact with predefined tools and execute actions based on user prompts.
  • Structured Output Generation: New sample illustrating how to generate structured JSON output from text using the Gemini model, facilitating easier parsing and integration of model responses into applications.
  • New Test Coverage: Addition of a new test file (live_examples_test.go) to validate the functionality of these new live generation samples, ensuring their correctness and reliability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds several new Go samples for GenAI live features, including grounded generation, function calling, and structured output. The code is generally well-structured, but there are a few issues to address.

In live_func_call_with_txt.go, there's a potential resource leak as the LiveSession is not closed, and a bug in handling tool call responses where responses are accumulated across calls.
In live_structured_ouput_with_txt.go, errors during JSON parsing are suppressed, which could lead to silent failures in tests.
The test file live_examples_test.go contains a leftover debug print statement.
The live_ground_googsearch_with_txt.go sample has inconsistent output handling, mixing writes to os.Stdout and the provided io.Writer.

Additionally, there's a typo in the filename genai/live/live_structured_ouput_with_txt.go (should be output).

I've added specific comments with suggestions for fixes.

@cfloress cfloress changed the title feat(genai): Add samples for live ground, func call and structured generation samples feat(genai): Add samples for live ground, func call and structured generation Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant