-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(genai): Add samples for live ground, func call and structured generation #5396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @cfloress, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds several new Go samples for GenAI live features, including grounded generation, function calling, and structured output. The code is generally well-structured, but there are a few issues to address.
In live_func_call_with_txt.go
, there's a potential resource leak as the LiveSession
is not closed, and a bug in handling tool call responses where responses are accumulated across calls.
In live_structured_ouput_with_txt.go
, errors during JSON parsing are suppressed, which could lead to silent failures in tests.
The test file live_examples_test.go
contains a leftover debug print statement.
The live_ground_googsearch_with_txt.go
sample has inconsistent output handling, mixing writes to os.Stdout
and the provided io.Writer
.
Additionally, there's a typo in the filename genai/live/live_structured_ouput_with_txt.go
(should be output
).
I've added specific comments with suggestions for fixes.
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
go test -v ./..
(see Testing)gofmt
(see Formatting)go vet
(see Formatting)