Skip to content

Conversation

@amcolin
Copy link

@amcolin amcolin commented Dec 23, 2025

Description

Replace the DetectLogos call with BatchAnnotateImages from cloud.google.com/go/vision/v2/apiv1, as it has been deprecated within the client library.

Internal: b/470281117

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@amcolin amcolin requested review from a team as code owners December 23, 2025 23:55
@product-auto-label product-auto-label bot added api: vision Issues related to the Cloud Vision API. samples Issues that are directly related to samples. labels Dec 23, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @amcolin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Google Cloud Vision API sample code to utilize the BatchAnnotateImages method, replacing the deprecated DetectLogos call. This ensures the samples remain functional, demonstrate current best practices, and maintain compatibility with the latest client library, thereby enhancing the reliability of the vision samples.

Highlights

  • API Migration: The DetectLogos function has been replaced with BatchAnnotateImages from the cloud.google.com/go/vision/v2/apiv1 package, addressing its deprecation within the client library.
  • Image Handling Update: The method for preparing images for API calls has been updated to align with the BatchAnnotateImages method's requirements, now using visionpb.Image with Content for local files and Source for URIs.
  • Response Parsing Adjustment: The code now iterates through response.Responses to correctly parse the results from the BatchAnnotateImages call, including error handling for individual responses.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly replaces the deprecated DetectLogos call with the BatchAnnotateImages call from the v2 API. The implementation looks good, but I've noticed a minor typo in a variable name in both of the updated functions. I've left suggestions to correct it. Otherwise, the changes are solid.

@amcolin amcolin force-pushed the fix-vision-logo-detection branch from d3aa064 to 6addf27 Compare December 23, 2025 23:59
@glasnt glasnt added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2026
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: vision Issues related to the Cloud Vision API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants