Skip to content

Conversation

@khilan-crest
Copy link

Adding samples for delete secret annotations

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@google-cla
Copy link

google-cla bot commented Jan 9, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples. labels Jan 9, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @khilan-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Google Cloud Secret Manager Go samples by adding new functionalities for managing secret annotations. It provides clear, executable examples for deleting annotations from both globally managed and regionally managed secrets, along with robust system tests to validate these operations. This update improves the utility of the sample library for developers needing to programmatically manage secret metadata.

Highlights

  • New Sample: Delete Secret Annotation: Introduced a new Go sample (delete_secret_annotation.go) demonstrating how to delete an annotation from a Google Cloud Secret Manager secret. This involves fetching the secret, removing the specified annotation from its map, and then updating the secret with the modified annotations.
  • New Regional Sample: Delete Regional Secret Annotation: Added a corresponding regional Go sample (delete_regional_secret_annotation.go) that illustrates the process of deleting an annotation from a regional Secret Manager secret. This sample explicitly configures the client to connect to a regional endpoint.
  • Comprehensive Testing: New system tests (TestDeleteSecretAnnotation and TestDeleteRegionalSecretAnnotation) have been added to secretmanager_test.go and regional_secretmanager_test.go respectively, ensuring the correct functionality of both the global and regional delete annotation samples.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds new samples for deleting secret annotations in both global and regional contexts, along with corresponding tests. The implementation is straightforward and correct. I've provided a few suggestions to improve the new sample functions by making them more reusable and to enhance the tests by increasing their coverage to include failure scenarios.

@khilan-crest khilan-crest marked this pull request as ready for review January 9, 2026 12:00
@khilan-crest khilan-crest requested review from a team as code owners January 9, 2026 12:00
@snippet-bot
Copy link

snippet-bot bot commented Jan 9, 2026

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant