feat(secretmanager): Adding secret delayed destruction sample

[khilan-crest]

Adding secret delayed destruction sample

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

• I have followed Contributing Guidelines from CONTRIBUTING.MD
• Tests pass: go test -v ./.. (see Testing)
• Code formatted: gofmt (see Formatting)
• Vetting pass: go vet (see Formatting)
• These samples need a new API enabled in testing projects to pass (let us know which ones)
• These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
• This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
• This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
• Please merge this PR for me once it is approved

[gemini-code-assist]

Summary of Changes

Hello @khilan-crest, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Google Cloud Secret Manager Go samples by adding functionality for delayed secret destruction. It provides clear examples for setting a Time-To-Live on secret versions during creation, modifying this TTL on existing secrets, and completely removing the delayed destruction configuration. These additions improve the sample library's coverage of Secret Manager features, particularly for managing secret lifecycle with time-based destruction policies.

Highlights

• New Samples for Delayed Secret Destruction: Introduced new Go samples demonstrating how to create, update, and remove secrets with a VersionDestroyTtl (Time-To-Live) in Google Cloud Secret Manager.
• Global and Regional Support: The new samples cover both global and regional Secret Manager operations, providing comprehensive examples for managing delayed destruction across different deployment types.
• Comprehensive Test Coverage: Added new system tests to verify the functionality of creating, updating, and deleting secrets with delayed destruction for both global and regional configurations.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds new samples for managing delayed destruction of secrets in Secret Manager, for both global and regional secrets. The new samples are well-written and cover creation, update, and deletion of the VersionDestroyTtl property. The accompanying tests are also comprehensive. I've identified a few minor issues in the test code, including a typo and some inconsistencies in test setup, and a small inconsistency in a sample tag. My suggestions aim to improve the clarity and maintainability of the code.

[snippet-bot]

Here is the summary of changes.

You are about to add 28 region tags.

• secretmanager/bind_tags_to_secret.go:17, tag secretmanager_bind_tags_to_secret
• secretmanager/create_secret_with_delayed_destroy.go:17, tag secretmanager_create_secret_with_delayed_destroy
• secretmanager/create_secret_with_expire_time.go:17, tag secretmanager_create_secret_with_expire_time
• secretmanager/create_secret_with_rotation.go:17, tag secretmanager_create_secret_with_rotation
• secretmanager/create_secret_with_topic.go:17, tag secretmanager_create_secret_with_topic
• secretmanager/delete_secret_annotation.go:17, tag secretmanager_delete_secret_annotation
• secretmanager/delete_secret_delayed_destroy.go:17, tag secretmanager_delete_delayed_destroy
• secretmanager/delete_secret_expiration.go:17, tag secretmanager_delete_secret_expiration
• secretmanager/delete_secret_rotation.go:17, tag secretmanager_delete_secret_rotation
• secretmanager/detach_tag_binding.go:17, tag secretmanager_detach_tag_binding
• secretmanager/list_tag_bindings.go:17, tag secretmanager_list_tag_bindings
• secretmanager/regional_samples/bind_tags_to_regional_secret.go:17, tag secretmanager_bind_tag_to_regional_secret
• secretmanager/regional_samples/create_regional_secret_with_delayed_destroy.go:17, tag secretmanager_create_regional_secret_with_delayed_destroy
• secretmanager/regional_samples/create_regional_secret_with_expire_time.go:17, tag secretmanager_create_regional_secret_with_expire_time
• secretmanager/regional_samples/create_regional_secret_with_rotation.go:17, tag secretmanager_create_regional_secret_with_rotation
• secretmanager/regional_samples/create_regional_secret_with_topic.go:17, tag secretmanager_create_regional_secret_with_topic
• secretmanager/regional_samples/delete_regional_secret_annotation.go:17, tag secretmanager_delete_regional_secret_annotation
• secretmanager/regional_samples/delete_regional_secret_delayed_destroy.go:17, tag secretmanager_delete_regional_secret_delayed_destroy
• secretmanager/regional_samples/delete_regional_secret_expiration.go:17, tag secretmanager_delete_regional_secret_expiration
• secretmanager/regional_samples/delete_regional_secret_rotation.go:17, tag secretmanager_delete_regional_secret_rotation
• secretmanager/regional_samples/detach_regional_tag_binding.go:17, tag secretmanager_detach_regional_tag_binding
• secretmanager/regional_samples/list_regional_secret_tag_bindings.go:17, tag secretmanager_list_regional_secret_tag_bindings
• secretmanager/regional_samples/update_regional_secret_expiration.go:17, tag secretmanager_update_regional_secret_expiration
• secretmanager/regional_samples/update_regional_secret_rotation.go:17, tag secretmanager_update_regional_secret_rotation_period
• secretmanager/regional_samples/update_regional_secret_with_delayed_destroy.go:17, tag secretmanager_update_regional_secret_with_delayed_destroy
• secretmanager/update_secret_expiration.go:17, tag secretmanager_update_secret_expiration
• secretmanager/update_secret_rotation.go:17, tag secretmanager_update_secret_rotation_period
• secretmanager/update_secret_with_delayed_destroy.go:17, tag secretmanager_update_secret_with_delayed_destroy

---

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

• Refresh this comment