fix(memorystore): fix outdated App Engine config for connecting to a …

[craig08]

…Memorystore instance

Description

Fixes #5452

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

• I have followed Contributing Guidelines from CONTRIBUTING.MD
• Tests pass: go test -v ./.. (see Testing)
• Code formatted: gofmt (see Formatting)
• Vetting pass: go vet (see Formatting)
• These samples need a new API enabled in testing projects to pass (let us know which ones)
• These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
• This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
• This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
• Please merge this PR for me once it is approved

[gemini-code-assist]

Summary of Changes

Hello @craig08, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the App Engine configuration files for Memorystore Redis deployment examples. The changes ensure that the sample applications leverage current and supported runtime environments, addressing outdated settings that could lead to deployment issues or deprecation warnings. This improves the overall reliability and future-proofing of the provided examples.

Highlights

• App Engine Flex Configuration Update: The app.yaml for App Engine Flex deployments now includes a runtime_config block, explicitly setting the operating system to ubuntu22. This ensures compatibility with current App Engine Flex environments.
• App Engine Standard Go Runtime Upgrade: The app.yaml for App Engine Standard deployments has been updated to use go125 as the runtime, moving from the older go111. This aligns the sample with a more recent and supported Go version.

Changelog

• memorystore/redis/gae_flex_deployment/app.yaml
  • Added runtime_config block with operating_system: "ubuntu22".
• memorystore/redis/gae_standard_deployment/app.yaml
  • Updated the runtime from go111 to go125.

Activity

• The pull request was opened by craig08 to fix outdated App Engine configurations for connecting to Memorystore instances.
• The author has completed the checklist items for contributing guidelines, tests, code formatting, and vetting.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates App Engine configuration files for Memorystore samples. The change for the App Engine Flex deployment correctly updates the configuration to use a modern operating system. However, the update for the App Engine Standard deployment specifies an invalid Go runtime version (go125), which will cause deployments to fail. I have provided a comment with a suggested correction to a valid and recent runtime version.

[amcolin]

Thanks for taking the time to update this!. Code changes look good to me 👍