Using the FQDN of a GCE instance instead of the IP address. (#815)

* Creating the FQDN of an instance.

* Adding FQDN to the item.

* Adding tests for the new method.

* Removing unnecessary UI change.

Author: ivannaranjo

GoogleCloudExtension/GoogleCloudExtension.DataSources.UnitTests/GoogleCloudExtension.DataSources.UnitTests.csproj

@@ -61,6 +61,10 @@
       <HintPath>..\packages\Google.Apis.CloudResourceManager.v1.1.29.1.993\lib\net45\Google.Apis.CloudResourceManager.v1.dll</HintPath>
       <Private>True</Private>
     </Reference>
+    <Reference Include="Google.Apis.Compute.v1, Version=1.29.1.981, Culture=neutral, PublicKeyToken=4b01fa6e34db77ab, processorArchitecture=MSIL">
+      <HintPath>..\packages\Google.Apis.Compute.v1.1.29.1.981\lib\net45\Google.Apis.Compute.v1.dll</HintPath>
+      <Private>True</Private>
+    </Reference>
     <Reference Include="Google.Apis.Core, Version=1.29.1.0, Culture=neutral, PublicKeyToken=4b01fa6e34db77ab, processorArchitecture=MSIL">
       <HintPath>..\packages\Google.Apis.Core.1.29.1\lib\net45\Google.Apis.Core.dll</HintPath>
       <Private>True</Private>
@@ -97,6 +101,7 @@
     </Otherwise>
   </Choose>
   <ItemGroup>
+    <Compile Include="InstanceExtensionsUnitTests.cs" />
     <Compile Include="ResourceManagerDataSourceUnitTests.cs" />
     <Compile Include="DataSourceUnitTestsBase.cs" />
     <Compile Include="PubSubDataSourceUnitTests.cs" />

GoogleCloudExtension/GoogleCloudExtension.DataSources.UnitTests/InstanceExtensionsUnitTests.cs

@@ -0,0 +1,64 @@
+// Copyright 2017 Google Inc. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+using Google.Apis.Compute.v1.Data;
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+using System.Collections.Generic;
+
+namespace GoogleCloudExtension.DataSources.UnitTests
+{
+    /// <summary>
+    /// Tests for the <seealso cref="InstanceExtensions"/> class.
+    /// </summary>
+    [TestClass]
+    public class InstanceExtensionsUnitTests
+    {
+        private static readonly Instance s_sampleInstance = new Instance
+        {
+            NetworkInterfaces = new List<NetworkInterface>
+            {
+                new NetworkInterface
+                {
+                    AccessConfigs = new List<AccessConfig>
+                    {
+                        new AccessConfig { NatIP = "1.2.3.4" }
+                    }
+                }
+            }
+        };
+
+        private const string ExpectedSampleInstanceFQDN = "4.3.2.1.bc.googleusercontent.com";
+
+        /// <summary>
+        /// This test ensures that we get the right FQDN from a chosen instance.
+        /// </summary>
+        [TestMethod]
+        public void GetFQDNTest()
+        {
+            var actual = s_sampleInstance.GetFullyQualifiedDomainName();
+            Assert.AreEqual(ExpectedSampleInstanceFQDN, actual);
+        }
+
+        /// <summary>
+        /// This test ensure that we get an empty string from an instnace that doesn't have an IP.
+        /// </summary>
+        [TestMethod]
+        public void GetNullFQDNTest()
+        {
+            Instance noPublicIpInstance = new Instance();
+            var actual = noPublicIpInstance.GetFullyQualifiedDomainName();
+            Assert.AreEqual("", actual);
+        }
+    }
+}

GoogleCloudExtension/GoogleCloudExtension.DataSources.UnitTests/packages.config

@@ -4,6 +4,7 @@
   <package id="Google.Apis" version="1.29.1" targetFramework="net452" />
   <package id="Google.Apis.Auth" version="1.29.1" targetFramework="net452" />
   <package id="Google.Apis.CloudResourceManager.v1" version="1.29.1.993" targetFramework="net452" />
+  <package id="Google.Apis.Compute.v1" version="1.29.1.981" targetFramework="net452" />
   <package id="Google.Apis.Core" version="1.29.1" targetFramework="net452" />
   <package id="Google.Apis.Pubsub.v1" version="1.29.1.971" targetFramework="net452" />
   <package id="Moq" version="4.7.127" targetFramework="net452" />

GoogleCloudExtension/GoogleCloudExtension.DataSources/InstanceExtensions.cs

@@ -139,6 +139,23 @@ public static string GetInternalIpAddress(this Instance instance) =>
         public static string GetPublicIpAddress(this Instance instance) =>
             instance.NetworkInterfaces?.FirstOrDefault()?.AccessConfigs?.FirstOrDefault()?.NatIP;
 
+        /// <summary>
+        /// Returns the FQDN for an instance in GCE.
+        /// </summary>
+        /// <param name="instance">The instance to inspect.</param>
+        /// <returns></returns>
+        public static string GetFullyQualifiedDomainName(this Instance instance)
+        {
+            var ipAddress = instance.GetPublicIpAddress();
+            if (ipAddress == null)
+            {
+                return "";
+            }
+
+            var reverseIp = string.Join(".", ipAddress.Split('.').Reverse());
+            return $"{reverseIp}.bc.googleusercontent.com";
+        }
+
         /// <summary>
         /// Returns a string with all of the tags for the instance.
         /// </summary>

GoogleCloudExtension/GoogleCloudExtension/Resources.Designer.cs

@@ -59,7 +59,7 @@ public static void WriteRdpFile(string path, Instance instance, WindowsInstanceC
             using (var writer = new StreamWriter(path))
             {
                 // The IP (or name) of the VM to connect to.
-                writer.WriteLine($"full address:s:{instance.GetPublicIpAddress()}");
+                writer.WriteLine($"full address:s:{instance.GetFullyQualifiedDomainName()}");
 
                 // The user name to use.
                 writer.WriteLine($"username:s:{credentials.User}");