Remove unnecessary extra ip route calls when checking for routes to add and delete in network module.#302
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Remove unnecessary extra ip route calls when checking for routes to add and delete in network module.#302copybara-service[bot] wants to merge 1 commit intomainfrom
ip route calls when checking for routes to add and delete in network module.#302copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_874856285
branch
6 times, most recently
from
d505152 to
80d52f2
Compare
… add and delete in `network` module. Currently, the `ip route` check happens twice -- once when checking if there are missing routes and extra routes, and another time when we actually add missing routes/remove extra routes. This optimization makes it so that we store the extra/missing routes upon the first check, and use those for the actual route setup instead of checking again. PiperOrigin-RevId: 874856285
copybara-service
bot
force-pushed
the
test_874856285
branch
from
80d52f2 to
796fef4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unnecessary extra
ip routecalls when checking for routes to add and delete innetworkmodule.Currently, the
ip routecheck happens twice -- once when checking if there are missing routes and extra routes, and another time when we actually add missing routes/remove extra routes. This optimization makes it so that we store the extra/missing routes upon the first check, and use those for the actual route setup instead of checking again.