Skip to content

Commit 8c0bb5c

Browse files
Fixed tests
1 parent 382324c commit 8c0bb5c

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

compute/cloud-client/src/test/java/compute/Util.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public abstract class Util {
5757
// resources
5858
// and delete the listed resources based on the timestamp.
5959

60-
private static final int DELETION_THRESHOLD_TIME_MINUTES = 20;
60+
private static final int DELETION_THRESHOLD_TIME_MINUTES = 25;
6161
// comma separate list of zone names
6262
private static final String TEST_ZONES_NAME = "JAVA_DOCS_COMPUTE_TEST_ZONES";
6363
private static final String DEFAULT_ZONES = "us-central1-a,us-west1-a,asia-south1-a";

compute/cloud-client/src/test/java/compute/disks/HyperdisksIT.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,13 +71,13 @@ public static void setUp()
7171
@AfterAll
7272
public static void cleanup()
7373
throws IOException, InterruptedException, ExecutionException, TimeoutException {
74+
Util.deleteStoragePool(PROJECT_ID, ZONE, STORAGE_POOL_NAME);
75+
Util.cleanUpExistingDisks("test-hyperdisk-enc-", PROJECT_ID, ZONE);
76+
Util.cleanUpExistingStoragePool("test-", PROJECT_ID, ZONE);
77+
7478
// Delete all disks created for testing.
7579
DeleteDisk.deleteDisk(PROJECT_ID, ZONE, HYPERDISK_NAME);
7680
DeleteDisk.deleteDisk(PROJECT_ID, ZONE, HYPERDISK_IN_POOL_NAME);
77-
78-
Util.deleteStoragePool(PROJECT_ID, ZONE, STORAGE_POOL_NAME);
79-
Util.cleanUpExistingDisks("test-hyperdisk-enc-", PROJECT_ID, ZONE);
80-
Util.cleanUpExistingStoragePool("test-" , PROJECT_ID, ZONE);
8181
}
8282

8383
@Test

compute/cloud-client/src/test/java/compute/reservation/ReservationIT.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,13 @@ public static void cleanup()
111111
final PrintStream out = System.out;
112112
ByteArrayOutputStream stdOut = new ByteArrayOutputStream();
113113
System.setOut(new PrintStream(stdOut));
114+
// Cleanup existing stale resources.
115+
Util.cleanUpExistingInstanceTemplates("test-global-inst-temp-" + javaVersion, PROJECT_ID);
116+
Util.cleanUpExistingRegionalInstanceTemplates(
117+
"test-regional-inst-temp-" + javaVersion, PROJECT_ID, ZONE);
118+
Util.cleanUpExistingReservations(
119+
"test-reserv-global-" + javaVersion, PROJECT_ID, ZONE);
120+
Util.cleanUpExistingReservations("test-reserv-regional-" + javaVersion, PROJECT_ID, ZONE);
114121

115122
// Delete instance template with GLOBAL location.
116123
DeleteInstanceTemplate.deleteInstanceTemplate(PROJECT_ID, GLOBAL_INSTANCE_TEMPLATE_NAME);
@@ -137,13 +144,6 @@ public static void cleanup()
137144
NotFoundException.class,
138145
() -> GetReservation.getReservation(PROJECT_ID, RESERVATION_NAME_REGIONAL, ZONE));
139146

140-
// Cleanup existing stale resources.
141-
Util.cleanUpExistingInstanceTemplates("test-global-inst-temp-" + javaVersion, PROJECT_ID);
142-
Util.cleanUpExistingRegionalInstanceTemplates(
143-
"test-regional-inst-temp-" + javaVersion, PROJECT_ID, ZONE);
144-
Util.cleanUpExistingReservations(
145-
"test-reserv-global-" + javaVersion, PROJECT_ID, ZONE);
146-
Util.cleanUpExistingReservations("test-reserv-regional-" + javaVersion, PROJECT_ID, ZONE);
147147

148148
// Close the client after all tests
149149
reservationsClient.close();

0 commit comments

Comments
 (0)