-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat: add new GenAI SDK text generation samples #10144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add new GenAI SDK text generation samples #10144
Conversation
Here is the summary of changes. You are about to add 5 region tags.
This comment is generated by snippet-bot.
|
Warning Gemini encountered an error creating the summary. You can try again by commenting |
/gemini summary |
Summary of ChangesI've introduced a set of new text generation samples for the GenAI SDK, expanding its capabilities to handle various input types. These additions include samples for asynchronous text generation from text, generating text from multiple local images, and extracting information from mute videos, PDFs, and YouTube videos. My aim is to provide comprehensive examples that showcase the SDK's versatility in multimodal content understanding and generation. Additionally, I've performed some minor code cleanup by removing unused imports in existing files. Highlights
Changelog
Activity
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds several new text generation samples for the GenAI SDK, demonstrating features like asynchronous calls, and using various inputs such as multiple local images, videos, and PDFs. The changes also include cleanup of unused imports in existing files and adding corresponding integration tests for the new samples. My review focuses on improving code consistency, readability, and test conciseness. I've suggested using System.out.print
for consistent output, adopting Java text blocks for better readability of multi-line strings, and removing redundant assertions in the new tests.
Description
Add new text generation samples (1):
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
mvn clean verify
requiredmvn -P lint checkstyle:check
requiredmvn -P lint clean compile pmd:cpd-check spotbugs:check
advisory only