Skip to content

fix(deps): replace dependency jstl:jstl with javax.servlet:jstl 1.1.2 #10170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix(deps): replace dependency jstl:jstl with javax.servlet:jstl 1.1.2 #10170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions appengine-java21/ee8/analytics/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,9 @@
</dependency>

<dependency>
<groupId>jstl</groupId>
<groupId>javax.servlet</groupId>
<artifactId>jstl</artifactId>
<version>1.2</version>
<version>1.1.2</version>
</dependency>
Comment on lines 60 to 64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While replacing the non-standard jstl:jstl dependency with the standard javax.servlet:jstl is a good practice, downgrading the version from 1.2 to 1.1.2 is not recommended. This project uses the Servlet 3.1 API, and the corresponding version for JSTL is 1.2. Using an older version like 1.1.2 is meant for older Servlet 2.3 containers and could lead to compatibility issues. It's best to use the version that aligns with the Servlet specification used in the project.

Suggested change
<dependency>
<groupId>jstl</groupId>
<groupId>javax.servlet</groupId>
<artifactId>jstl</artifactId>
<version>1.2</version>
<version>1.1.2</version>
</dependency>
<dependency>
<groupId>javax.servlet</groupId>
<artifactId>jstl</artifactId>
<version>1.2</version>
</dependency>


<dependency>
Expand Down