ci(cloud-sql): skip failing tests #10179
Conversation
product-auto-label
bot
added
api: cloudsql
Summary of ChangesHello @glasnt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request temporarily disables several failing integration tests across the Cloud SQL Java servlet samples for MySQL, PostgreSQL, and SQL Server. The tests, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request skips several failing Cloud SQL servlet tests by using the @Ignore annotation. This is a reasonable approach to unblock the CI pipeline while the tests are being refactored. The changes are clear and directly address the issue. I've added a few suggestions to improve maintainability by using a constant for the issue URL.
| } | ||
|
|
||
| @Test | ||
| @Ignore("https://github.com/GoogleCloudPlatform/java-docs-samples/issues/8794") |
There was a problem hiding this comment.
To improve maintainability and avoid duplicating the issue URL, consider defining it as a private static final String constant. This constant can then be used here and for the other ignored test on line 115.
For example:
private static final String SKIP_FAILING_TESTS_ISSUE = "https://github.com/GoogleCloudPlatform/java-docs-samples/issues/8794";
// ...
@Ignore(SKIP_FAILING_TESTS_ISSUE)| } | ||
|
|
||
| @Test | ||
| @Ignore("https://github.com/GoogleCloudPlatform/java-docs-samples/issues/8794") |
There was a problem hiding this comment.
To improve maintainability and avoid duplicating the issue URL, consider defining it as a private static final String constant. This constant can then be used here and for the other ignored test on line 116.
For example:
private static final String SKIP_FAILING_TESTS_ISSUE = "https://github.com/GoogleCloudPlatform/java-docs-samples/issues/8794";
// ...
@Ignore(SKIP_FAILING_TESTS_ISSUE)|
|
||
|
|
||
| @Test | ||
| @Ignore("https://github.com/GoogleCloudPlatform/java-docs-samples/issues/8794") |
There was a problem hiding this comment.
To improve maintainability and avoid duplicating the issue URL, consider defining it as a private static final String constant. This constant can then be used here and for the other ignored test on line 125.
For example:
private static final String SKIP_FAILING_TESTS_ISSUE = "https://github.com/GoogleCloudPlatform/java-docs-samples/issues/8794";
// ...
@Ignore(SKIP_FAILING_TESTS_ISSUE)2 participants
As noted in #8794, these tests require refactoring.
They are currently failing and is blocking #10129
This PR skips these tests, pending rework.
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only