ci(container-registry): skip tests #10181
Conversation
product-auto-label
bot
added
samples
Summary of ChangesHello @glasnt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a temporary measure to skip several integration tests in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request disables all tests in SamplesTest.java by adding @Ignore annotations to each test method, referencing an issue. While this achieves the goal, a more maintainable approach would be to use a single @Ignore annotation at the class level, since all tests are being skipped for the same reason. My review includes suggestions to remove the individual annotations from each method to facilitate this refactoring. This will make the code cleaner and easier to manage when the tests are eventually re-enabled.
| } | ||
|
|
||
| @Test | ||
| @Ignore("https://github.com/GoogleCloudPlatform/java-docs-samples/issues/10180") |
There was a problem hiding this comment.
Since all tests in this class are being ignored for the same reason, it would be cleaner to add a single @Ignore annotation to the SamplesTest class instead of annotating each test method individually. This would make the code more concise and easier to maintain when the tests are re-enabled. Please remove this annotation and add @Ignore("https://github.com/GoogleCloudPlatform/java-docs-samples/issues/10180") to the SamplesTest class.
| } | ||
|
|
||
| @Test | ||
| @Ignore("https://github.com/GoogleCloudPlatform/java-docs-samples/issues/10180") |
There was a problem hiding this comment.
As per the suggestion on testCreateNote, a single class-level @Ignore annotation should be used. Please remove this redundant method-level annotation.
| } | ||
|
|
||
| @Test | ||
| @Ignore("https://github.com/GoogleCloudPlatform/java-docs-samples/issues/10180") |
There was a problem hiding this comment.
As per the suggestion on testCreateNote, a single class-level @Ignore annotation should be used. Please remove this redundant method-level annotation.
| } | ||
|
|
||
| @Test | ||
| @Ignore("https://github.com/GoogleCloudPlatform/java-docs-samples/issues/10180") |
There was a problem hiding this comment.
As per the suggestion on testCreateNote, a single class-level @Ignore annotation should be used. Please remove this redundant method-level annotation.
| } | ||
|
|
||
| @Test | ||
| @Ignore("https://github.com/GoogleCloudPlatform/java-docs-samples/issues/10180") |
There was a problem hiding this comment.
As per the suggestion on testCreateNote, a single class-level @Ignore annotation should be used. Please remove this redundant method-level annotation.
| } | ||
|
|
||
| @Test | ||
| @Ignore("https://github.com/GoogleCloudPlatform/java-docs-samples/issues/10180") |
There was a problem hiding this comment.
As per the suggestion on testCreateNote, a single class-level @Ignore annotation should be used. Please remove this redundant method-level annotation.
| } | ||
|
|
||
| @Test | ||
| @Ignore("https://github.com/GoogleCloudPlatform/java-docs-samples/issues/10180") |
There was a problem hiding this comment.
As per the suggestion on testCreateNote, a single class-level @Ignore annotation should be used. Please remove this redundant method-level annotation.
| } | ||
|
|
||
| @Test | ||
| @Ignore("https://github.com/GoogleCloudPlatform/java-docs-samples/issues/10180") |
There was a problem hiding this comment.
As per the suggestion on testCreateNote, a single class-level @Ignore annotation should be used. Please remove this redundant method-level annotation.
| } | ||
|
|
||
| @Test | ||
| @Ignore("https://github.com/GoogleCloudPlatform/java-docs-samples/issues/10180") |
There was a problem hiding this comment.
As per the suggestion on testCreateNote, a single class-level @Ignore annotation should be used. Please remove this redundant method-level annotation.
| } | ||
|
|
||
| @Test | ||
| @Ignore("https://github.com/GoogleCloudPlatform/java-docs-samples/issues/10180") |
There was a problem hiding this comment.
As per the suggestion on testCreateNote, a single class-level @Ignore annotation should be used. Please remove this redundant method-level annotation.
1 participant
Description
Addresses #10180
Unblocks #10129
Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only