Skip to content

Conversation

glasnt
Copy link
Contributor

@glasnt glasnt commented Oct 10, 2025

Description

Addresses #10129

This check is currently failing with expected: 16252 but was: 16708.

I don't think checking the specific amount of tokens used is useful, as I don't believe this number would be a constant as we continue to update the version of Gemini used for these tests.

Python and Golang might have comments (py, go on the amount of tokens, but the tests just confirm the function completed, not the output (py, go).

I've adjusted the tests to be less strict.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 10, 2025
@glasnt glasnt changed the title ci(vertexai): test for type, not for value ci(vertexai): remove specific token count test Oct 10, 2025
@glasnt glasnt added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 10, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 10, 2025
@glasnt glasnt marked this pull request as ready for review October 10, 2025 19:46
@glasnt glasnt requested review from a team and yoshi-approver as code owners October 10, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants