Merge from Main to ludo-java21 #9881
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added tpu_queued_resources_network sample * Changed CODEOWNERS * Update CreateQueuedResourceWithNetwork.java --------- Co-authored-by: Eric Schmidt <[email protected]>
* Implemented compute_reservation_create_from_vm sample. created test * Cleaned reservations * Fixed lint issue * Revert "Fixed lint issue" This reverts commit c758b03. * Reverted changes * Fixed naming * Fixed naming * Fixed naming * Fixed naming * Created new test class for CreateReservationFromVm * Changed zone * Cleaned unused code * Fixed test and naming
…ervation samples. (#9564) * Added compute_instance_not_consume_reservation sample and test. * Added timeout * Fixed test * Fixed test * Created ConsumeReservationIT cals, fixed ReservationIT * Fixed ReservationIT * changed zone * changed zone * Added compute_template_not_consume_reservation sample, fixed tests * Added timeout * Fixed Instance creation * Fixed Instance creation * Disabled Instance creation * Fixed code * Fixed comments * Added comments and code * Fixed code following recommendations
…6.v20240826 [security] (#9579)
* feat(dataplex): adjust snippets * feat(dataplex): fix small typos in tests * feat(dataplex): small adjustment in tests --------- Co-authored-by: Jacek Spalinski <[email protected]>
Co-authored-by: Jacek Spalinski <[email protected]>
* Added performance-provisioning-type, fixed test * fixed test * Enabled tests * Fixed whitespaces * Added comments * Fixed comments and zone * Fixed timeout and zone in test class * Fixed naming, added variable CAPACITY_PROVISIONING_TYPE * Fixed storagePoolType * Fixed lint issue
* Changed package, added information to CODEOWNERS * Added information to CODEOWNERS * Added timeout * Fixed parameters for test * Fixed DeleteTpuVm and naming * Added comment, created Util class * Fixed naming * Fixed whitespace * Split PR into smaller, deleted redundant code * Fixed tests, deleted cleanup method * Fixed tests
* Implemented consume reservation samples, created tests * Fixed code * Fixed code * Fixed indentation * Fixed comments * Fixed code following recommendations * Fixed return value * deleted empty line after tag * Fixed tests * Fixed tests * Fixed test * Fixed zone * Fixed zone * Cleanup reservations * Fixed lint issue * Fixed test * Changed zone for HyperdisksIT * Cleanup resources * Changed zone for HyperdisksIT * Added cleanup methods * Deleted cleanup methods * Deleted cleanup methods
* Implemented apikeys_undelete_api_key sample, created test * Fixed header
…Module code samples (Create, Delete, List, Get) (#9598) * sample code for CreateSecurityHealthAnalyticsCustomModule * sample code for DeleteSecurityHealthAnalyticsCustomModule * sample code for ListSecurityHealthAnalyticsCustomModules * sample code for GetSecurityHealthAnalyticsCustomModule * refactor region tag
* Changed tests * Created separated test for CreateTpuVm * Renamed file * Fixed imports * Fixed tests as requested in comments * Deleted redundant dependency * Fixed indentation * Fixed tests
* feat(dataplex): add sample for search Entries * feat(dataplex): add integration tests for search Entries * feat(dataplex): make searchEntries return SearchEntriesResponse to support paging * feat(dataplex): adjust integration test based on code review * feat(dataplex): adjust comment regarding search scope * feat(dataplex): remove paging from Search --------- Co-authored-by: Jacek Spalinski <[email protected]>
* Changed package, added information to CODEOWNERS * Added information to CODEOWNERS * Added timeout * Fixed parameters for test * Fixed DeleteTpuVm and naming * Added comment, created Util class * Fixed naming * Fixed whitespace * Split PR into smaller, deleted redundant code * Implemented tpu_vm_create_topology sample, created test * Changed zone * Fixed empty lines and tests, deleted cleanup method * Fixed tests * Fixed test * Fixed imports * Increased timeout to 10 sec * Fixed tests * Fixed tests * Deleted settings * Made ByteArrayOutputStream bout as local variable * Changed timeout to 10 sec
stack-info: PR: #9689, branch: igorbernstein2/stack/2
stack-info: PR: #9690, branch: igorbernstein2/stack/3
stack-info: PR: #9691, branch: igorbernstein2/stack/4
stack-info: PR: #9692, branch: igorbernstein2/stack/5
stack-info: PR: #9695, branch: igorbernstein2/stack/6
* fix: misc fixes for bigtable-proxy * fix dependecy conflict that shared-configuration created for the transitive dep google-cloud-core * some docs * typo in Verify & extract constants * hard fail if call options credentials receives are missing a tracer * rename the label apiclient -> api_client for readability * remove stray imports * format * presence typo * fix ping and warm * update readme for verify * add multiple response detection to ping and warm * fix comment * add a TODO for a debug metric
* Added tpu_queued_resources_network sample * Fixed samples and tests * Fixed tests * Changed CODEOWNERS * Split samples, fixed startup script path * Fixed style * Added tag * Added header * Implemented tpu_queued_resources_startup_script sample, created test * Fixed test, deleted cleanup method * Fixed test, deleted cleanup method * Fixed test * Fixed naming * Changed zone * Fixed tests * Fixed tests * Increased timeout * Fixed code as requested in comments * Deleted settings * Fixed test
* Implemented compute_consistency_group_create and compute_consistency_group_delete samples, created test * Implemented compute_consistency_group_add_disk sample * Implemented compute_consistency_group_add_disk sample, created test * Fixed naming * Implemented compute_consistency_group_list_disks sample, created test * Fixed code * Fixed code * Fixed code * Cleaned up reservations * Fixed import * Fixed code * Fixed zone * Fixed zone * Fixed test * Fixed code and test * Added check for zonal location and code * Deleted redundant code * Added compute_consistency_group_list_disks_zonal sample, created test * Fixed tests
product-auto-label
bot
added
samples
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
ghost
reviewed
Dec 16, 2024
There was a problem hiding this comment.
Hi @ludoch, Gemini is currently reviewing this pull request and will post a full review in a few minutes. In the meantime, here's a summary for you and other reviewers to quickly grasp the changes and their purpose:
This pull request merges changes from the main branch into the ludo-java21 branch. The primary changes involve updating the CODEOWNERS file to add the tpu directory and adjust team assignments for several other directories, reflecting organizational changes. Specifically, the opencensus and trace directories were removed from the DEE Platform Ops section, and the cloud-sql directory's team assignment was updated. Additionally, the renovate.json5 file was updated to improve dependency management, primarily by switching to JSON5 format and updating various rules for auto-merging and version control. Finally, some pom.xml files were updated to newer versions of Jetty, and some Java files were updated to remove deprecated code.
If there's any missing context, please let me know. I did my best to summarize based on the available information.
Small changes made with care,
Code flows, a world to share,
Reviews make it fair.
|
Gemini encountered an error creating the review. You can try again by commenting |
|
@ludoch can you refresh your branch from main and only submit changes for review for the changes you are initiating? This looks like you might have been working from a stale branch. |
iennae
requested changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.