tests: add smoketest using kind by justinsb · Pull Request #4506 · GoogleCloudPlatform/k8s-config-connector

justinsb · 2025-05-08T14:22:17Z

The start of an e2e smoketest that deploys into a cluster with the operator.

A few (bigger) todos:

We should figure out how to capture the GCP traffic
We should ensure that we are running the images we actually push

justinsb · 2025-05-13T19:49:36Z

This is obviously only a first step, but the reconciler did run:

  Warning  UpdateFailed  1s    storagebucket-controller  Update call failed: error fetching live state: error reading underlying resource: summary: Error when reading or editing Storage Bucket "kcc-test-config-control": Get "https://storage.googleapis.com/storage/v1/b/kcc-test-config-control?alt=json&prettyPrint=false": oauth2: cannot fetch token: 400 Bad Request
Response: {"error":"invalid_grant","error_description":"Invalid grant: account not found"}

jingyih · 2025-05-15T17:37:36Z

/assign @xiaoweim

xiaoweim · 2025-06-20T21:22:33Z

.github/workflows/ci-presubmit.yaml

      - uses: actions/setup-go@v5
        with:
          go-version-file: 'go.mod'
-      - name: "Run scripts/github-actions/tests-scenarios-acquisition"


Out of curiosity, are we replacing the tests-scenarios-acquisition with the smoke test completely? The smoke test looks.

Ah good point, I forgot about that problem.

So .github/workflows/ci-presubmit.yaml is # Generated by dev/tasks/generate-github-actions (line 15)

I think it was manually edited to add the additional tasks, and we do need to fix that. Two ways I can think of:

Move the manual edits to a manually maintained yaml file (so they won't get deleted when we regenerate)

Ensure that the automatic generation recreates these tasks by adding them to the locations that dev/tasks/generate-github-actions looks at

Sounds good (and I like the second option for the script take care of the tasks) :)

xiaoweim · 2025-07-08T22:56:10Z

/lgtm

xiaoweim · 2025-07-08T22:57:24Z

/assign @cheftako

justinsb · 2025-07-29T19:46:38Z

ping @cheftako

justinsb · 2025-09-19T23:18:20Z

/assign @xiaoweim

justinsb · 2025-09-20T11:09:05Z

Issue #5224

justinsb · 2025-09-25T15:02:13Z

Can we get this PR in cc @xiaoweim @cheftako

xiaoweim · 2025-09-30T00:28:05Z

/lgtm
/approve

The start of an e2e smoketest that deploys into a cluster with the operator. A few (bigger) todos: * We should figure out how to capture the GCP traffic * We should ensure that we are running the images we actually push

google-oss-prow · 2026-01-21T18:37:46Z

New changes are detected. LGTM label has been removed.

google-oss-prow · 2026-01-21T18:38:11Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xiaoweim
Once this PR has been reviewed and has the lgtm label, please ask for approval from cheftako. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cheftako · 2026-01-28T00:18:14Z

.github/workflows/ci-presubmit.yaml

+    timeout-minutes: 60
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-go@4dc6199c7b1a012772edbd06daecab0f50c9053c # v6.1.0


Yuck. V6.2.0 is out. Could we use either the actual v6.1.0 or v6.2.0?

cheftako · 2026-01-28T00:18:48Z

dev/ci/presubmits/smoketest-with-kind

@@ -0,0 +1,87 @@
+#!/usr/bin/env bash
+# Copyright 2024 Google LLC


cheftako · 2026-01-28T00:21:56Z

dev/ci/presubmits/smoketest-with-kind

+echo "Creating namespace ${NS}"
+kubectl create ns ${NS} --dry-run=client -oyaml | kubectl apply --server-side -f -
+
+# echo "Creating ConfigConnectorContext in namespace ${NS} (with fake google service account)"


Do we want these large commented out blocks? I would also suggest it is probably clearer to create a CCC function, a StorageBucket function and then have the main code path call (or not) those functions.

cheftako · 2026-01-28T00:24:26Z

dev/tasks/deploy-to-kube


-if [[ -z "${VERSION:-}" ]]; then
-  echo "VERSION must be set"
+if [[ -z "${IMAGE_TAG:-}" ]]; then


AGENT: Renaming VERSION to IMAGE_TAG is a breaking change for any existing callers of this script. Please check if this script is used elsewhere (e.g., local development workflows) or support both variables.

cheftako · 2026-01-28T00:25:54Z

dev/tasks/deploy-to-kube


 kustomize build operator/config/default | \
-  sed -e "s@image: operator:.*@image: gcr.io/gke-release/cnrm/operator:${VERSION}@g" | \
+  sed -e "s@image: operator:.*@image: gcr.io/gke-release/cnrm/operator:${IMAGE_TAG}@g" | \


TAKO: At some future point I think we should start plumbing in the registry root. ('gcr.io/gke-release'). Once that is done it becomes a lot easier to generate dev builds and run them.

cheftako · 2026-01-28T00:37:24Z

dev/tasks/deploy-to-kube

-echo "Configuring namespace mode"
+# # Configure in namespace mode, per instructions at https://cloud.google.com/config-connector/docs/how-to/install-namespaced
+# echo "Configuring namespace mode"
+# cat <<EOF | kubectl apply --server-side -f -


Still thinking making functions out of these and then have the mainline more like:
Setup-namespace-mode()
Setup_CC()

cheftako · 2026-01-28T00:38:21Z

dev/tasks/deploy-to-kube

+# EOF
+
+# Configure in cluster mode so we can use a (fake) google service account
+echo "Creating namespace cnrm-system"


If we recommend namespace mode, then shouldn't out smoketest be to have namespace mode be the default test?

justinsb force-pushed the smoketest branch 9 times, most recently from c27223e to 9651ce8 Compare May 13, 2025 12:32

google-oss-prow bot assigned xiaoweim May 15, 2025

justinsb force-pushed the smoketest branch 3 times, most recently from 6136aa1 to 6f52a6b Compare May 16, 2025 21:24

justinsb force-pushed the smoketest branch 2 times, most recently from cb795f6 to 488358e Compare May 29, 2025 07:34

justinsb force-pushed the smoketest branch from 488358e to 8717a04 Compare June 10, 2025 16:26

xiaoweim reviewed Jun 20, 2025

View reviewed changes

google-oss-prow bot added the lgtm label Jul 8, 2025

google-oss-prow bot assigned cheftako Jul 8, 2025

justinsb force-pushed the smoketest branch from 8717a04 to 921974a Compare July 29, 2025 20:02

google-oss-prow bot removed the lgtm label Jul 29, 2025

justinsb force-pushed the smoketest branch 3 times, most recently from 3c0ef99 to 29d3890 Compare July 31, 2025 18:54

justinsb force-pushed the smoketest branch from 29d3890 to 6e29d7c Compare September 19, 2025 23:18

google-oss-prow bot added the lgtm label Sep 30, 2025

tests: add smoketest using kind

97239bd

The start of an e2e smoketest that deploys into a cluster with the operator. A few (bigger) todos: * We should figure out how to capture the GCP traffic * We should ensure that we are running the images we actually push

justinsb force-pushed the smoketest branch from 6e29d7c to 97239bd Compare January 21, 2026 18:37

google-oss-prow bot removed the lgtm label Jan 21, 2026

cheftako reviewed Jan 28, 2026

View reviewed changes

dev/ci/presubmits/smoketest-with-kind

@@ -0,0 +1,87 @@

#!/usr/bin/env bash

# Copyright 2024 Google LLC

Copy link

Collaborator

cheftako Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2026

cheftako reviewed Jan 28, 2026

View reviewed changes

justinsb mentioned this pull request Jan 28, 2026

Create smoketest in go #6343

Closed

		@@ -0,0 +1,87 @@
		#!/usr/bin/env bash
		# Copyright 2024 Google LLC

Conversation

justinsb commented May 8, 2025

Uh oh!

justinsb commented May 13, 2025

Uh oh!

jingyih commented May 15, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justinsb Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xiaoweim commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xiaoweim commented Jul 8, 2025

Uh oh!

justinsb commented Jul 29, 2025

Uh oh!

justinsb commented Sep 19, 2025

Uh oh!

justinsb commented Sep 20, 2025

Uh oh!

justinsb commented Sep 25, 2025

Uh oh!

xiaoweim commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

google-oss-prow bot commented Jan 21, 2026

Uh oh!

google-oss-prow bot commented Jan 21, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

justinsb Jun 23, 2025 •

edited

Loading

xiaoweim commented Jul 8, 2025 •

edited

Loading

xiaoweim commented Sep 30, 2025 •

edited

Loading