feat: Turn on CloudIdentityMembership direct controller#4855
feat: Turn on CloudIdentityMembership direct controller#4855google-oss-prow[bot] merged 1 commit intoGoogleCloudPlatform:masterfrom
Conversation
|
This LGTM! I don't have as much context as @yuwenma but I'd say to keep an eye on the postsubmits 💯 /lgtm (happy yo re-lgtm if you need to rebase) 📚 |
f4d1d1c to
cb84d0c
Compare
cb84d0c to
a0fa289
Compare
yuwenma
left a comment
There was a problem hiding this comment.
can we add the test to verify existing TF-based CloudIdentityMembership can smoothly migrate to the direct approach (without any user actions)
Yeah I also added this doc in the PR description: https://docs.google.com/document/d/1zaR2XNbG9Fw81TSuOpzmtowoyHj0YZfvc06ezgHWXFk/edit?resourcekey=0-h8xZEMPhxDBK73Fc4PB1KQ&tab=t.0#heading=h.yhpu0rq5gyd7 |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acpana, yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2b571dc
into
GoogleCloudPlatform:master
Change description
Based off of #4814, turn on CloudIdentityMembership direct controller
Special notes for your reviewer:
Test I've done:
E2E test to verify there's no changes to the created resource, after the switch from DCL to direct: CloudIdentity Sci-fi migration test coverage one-pager
PR to add comments and additional scenarios test to CloudIdentityMembership: tests: Add comments to CloudIdentity scenarios tests #4835
CloudIdentityMembership is considered a 'Important' tier in Joyce's analysis, so we have test coverage for all fields in our fixtures test, dynamic test and acquisition in our scenarios test.
Does this PR add something which needs to be 'release noted'?
Additional documentation e.g., references, usage docs, etc.:
Intended Milestone
Please indicate the intended milestone.
Tests you have done
make ready-prto ensure this PR is ready for review.