Skip to content

feat: Turn on CloudIdentityMembership direct controller#4855

Merged
google-oss-prow[bot] merged 1 commit intoGoogleCloudPlatform:masterfrom
gemmahou:turnon-direct2
Aug 15, 2025
Merged

feat: Turn on CloudIdentityMembership direct controller#4855
google-oss-prow[bot] merged 1 commit intoGoogleCloudPlatform:masterfrom
gemmahou:turnon-direct2

Conversation

@gemmahou
Copy link
Collaborator

@gemmahou gemmahou commented Jul 25, 2025

Change description

Based off of #4814, turn on CloudIdentityMembership direct controller

Special notes for your reviewer:

Test I've done:

CloudIdentityMembership is considered a 'Important' tier in Joyce's analysis, so we have test coverage for all fields in our fixtures test, dynamic test and acquisition in our scenarios test.

Does this PR add something which needs to be 'release noted'?

## Reconciliation Improvements

* [`CloudIdentityMembership`](https://cloud.google.com/config-connector/docs/reference/resource-docs/cloudidentity/cloudidentitymembership)

    * All CloudIdentityMembership types are now reconciled using the new direct controller (instead of the legacy DCL-based controller). The previous "opt-in" annotation (documented [here](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/docs/features/optin.md)) no longer applies. Users no longer need to apply the "opt-in" annotation to CloudIdentityMembership resources to enable the direct controller. Regardless of the presence (or absence) of an opt-in annotation on CloudIdentityMembership resources, the direct reconciler will be used.
  • Reviewer reviewed release note.

Additional documentation e.g., references, usage docs, etc.:


Intended Milestone

Please indicate the intended milestone.

  • Reviewer tagged PR with the actual milestone.

Tests you have done

  • Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.

@acpana
Copy link
Collaborator

acpana commented Aug 7, 2025

This LGTM! I don't have as much context as @yuwenma but I'd say to keep an eye on the postsubmits 💯

/lgtm
/approve

(happy yo re-lgtm if you need to rebase) 📚

Copy link
Collaborator

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add the test to verify existing TF-based CloudIdentityMembership can smoothly migrate to the direct approach (without any user actions)

@gemmahou
Copy link
Collaborator Author

can we add the test to verify existing TF-based CloudIdentityMembership can smoothly migrate to the direct approach (without any user actions)

Yeah I also added this doc in the PR description: https://docs.google.com/document/d/1zaR2XNbG9Fw81TSuOpzmtowoyHj0YZfvc06ezgHWXFk/edit?resourcekey=0-h8xZEMPhxDBK73Fc4PB1KQ&tab=t.0#heading=h.yhpu0rq5gyd7

@yuwenma
Copy link
Collaborator

yuwenma commented Aug 15, 2025

/lgtm

@yuwenma
Copy link
Collaborator

yuwenma commented Aug 15, 2025

/approve

@google-oss-prow google-oss-prow bot added the lgtm label Aug 15, 2025
@google-oss-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acpana, yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 2b571dc into GoogleCloudPlatform:master Aug 15, 2025
115 of 117 checks passed
@gemmahou gemmahou deleted the turnon-direct2 branch August 15, 2025 15:55
@gemmahou gemmahou added this to the 1.134 milestone Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants