tests: don't skip the webhooks in our tests#4882
Open
justinsb wants to merge 2 commits intoGoogleCloudPlatform:masterfrom
Open
tests: don't skip the webhooks in our tests#4882justinsb wants to merge 2 commits intoGoogleCloudPlatform:masterfrom
justinsb wants to merge 2 commits intoGoogleCloudPlatform:masterfrom
Conversation
justinsb
force-pushed
the
test_deny_immutable_field_updates_webhook
branch
4 times, most recently
from
7e665ec to
497a9e1
Compare
Collaborator
Author
|
At least some of these are "real": |
yuwenma
reviewed
Aug 2, 2025
Collaborator
yuwenma
left a comment
yuwenma
left a comment
There was a problem hiding this comment.
/approve
/lgtm
Awesome!
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
|
Justin can you rebase and see if that gets the tests to pass? |
Collaborator
Author
|
I think these are real failures, but yes ... rebasing to see if anyone has fixed them :-) |
justinsb
force-pushed
the
test_deny_immutable_field_updates_webhook
branch
from
497a9e1 to
0777e8f
Compare
Contributor
|
New changes are detected. LGTM label has been removed. |
We were skipping the deny-immutable-field-updates webhook, which meant that any problems here are harder to detect.
This is how our webhooks identify the KCC controllers, and allow them to make changes that would otherwise be immutable.
justinsb
force-pushed
the
test_deny_immutable_field_updates_webhook
branch
from
0777e8f to
347de46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were skipping the deny-immutable-field-updates webhook,
which meant that errors here are harder to detect.