linters: add tests for labels

[justinsb]

No description provided.

[justinsb]

/hold

We need to fix the lack of test coverage before we merge this one

[yuwenma]

/approve

Thanks! For cnrm.cloud.google.com/system"="true", another option is to add it to the kustomization which applies to the operator CRDs, so that we can guarantee the annotation without coding (and test) effort. https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/config/crds/kustomization.yaml

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [yuwenma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[yuwenma]

We need to fix the lack of test coverage before we merge this one

I'm okay to add the label coverage in a follow-up PR, and the exception should be removed.

I like the controller-type exception list! But we have no quick fixes right now:

• the "is not direct but has no TF or DCL labels" is due to missing direct controllers. The generate-types works well, but the direct controller has real issues, so it's not implemented yet
• the "is direct but has TF label" is due to beta TF/DCL resource has the direct as opt-in.

[justinsb]

But we have no quick fixes right now:

Right, I think it's OK to have exceptions here. I'll add some text to make it look less scary.

[justinsb]

another option is to add it to the kustomization

We should be committing correct CRDs in the repo (and not committing intermediates): for tests, for customers, for AI

[justinsb]

/assign @yuwenma