Cherry pick #4981 Adding preliminary label fix for alloydbinstance.#4983
Cherry pick #4981 Adding preliminary label fix for alloydbinstance.#4983cheftako wants to merge 3 commits intoGoogleCloudPlatform:release-1.132from
Conversation
Added gemini generate command of making a sanitize label fix. Added the result of running the gemini generate command. This includes the fix and the initial test.
|
/approve Non-blocker: Label is a generic issue that needs to be applied for all KCC resources (greenfield and brownfield). Suggest extending the label fixes to a broader scope. I would like to convert https://docs.google.com/document/d/1yBzlQmWbp5Q4B02pxe9kuegU9bp84A-cLotbEqzZgkg/edit?tab=t.0 to a gemini instruction or cmd. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| if resource.Labels == nil { | ||
| resource.Labels = make(map[string]string) | ||
| } | ||
| resource.Labels["managed-by-cnrm"] = "true" |
There was a problem hiding this comment.
nit: with NewGCPLabelsFromK8sLabels this line is no longer needed. as well as line 261
|
Closing in preference for making 1.134 the "stable" release |
5 participants
Change description
Fixes issue where outside/kubernetes labels are being incorrectly applied to the AlloyDBInstance.
Added gemini generate command of making a sanitize label fix. Added the result of running the gemini generate command. This includes the fix and the initial test.
Special notes for your reviewer:
Does this PR add something which needs to be 'release noted'?
Additional documentation e.g., references, usage docs, etc.:
Intended Milestone
1.132.2
Please indicate the intended milestone.
Tests you have done
make ready-prto ensure this PR is ready for review.