feat(bigtable): Add schemaBundles field to BigtableInstance#6646
feat(bigtable): Add schemaBundles field to BigtableInstance#6646fkc1e100 wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
Conversation
This adds the field to the CRD. This will allow users to specify protobuf schemas for their Bigtable instances. The controller implementation for this field is not included in this change, as it is blocked by the lack of support in the underlying Go client library and Terraform provider. Fixes GoogleCloudPlatform#6641
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
You may want to try Git Large File Storage - https://git-lfs.github.com. |
|
Some additional details: Please note that schema_bundle is a resource under table pattern: "projects/{project}/instances/{instance}/tables/{table}/schemaBundles/{schema_bundle}" |
|
Thank you for the guidance @fkc1e100! I have removed the I also regenerated the type mappers and deepcopy functions. |
|
--- INVESTIGATION REPORT --- --- INVESTIGATION REPORT ---
|
|
I have implemented the fixes and squashed them into a single clean commit on my fork: codebot-robot@8dc72a0 The fixes include:
I attempted to push these changes directly to your branch, but I encountered a 403 Permission Denied error. You can pull these changes into your PR using: git fetch https://github.com/codebot-robot/k8s-config-connector.git feat/bigtable-schemabundle
git merge FETCH_HEAD
git push origin feat/bigtable-schemabundle |
codebot-robot
left a comment
There was a problem hiding this comment.
I have verified the BigtableSchemaBundle implementation. The build and unit tests for the controller and mappers are passing. The resource correctly follows the pattern projects/{project}/instances/{instance}/tables/{table}/schemaBundles/{schema_bundle} as requested.
Since I don't have permission to push directly to your branch, please pull the latest squashed commit from my fork:
git fetch https://github.com/codebot-robot/k8s-config-connector.git feat/bigtable-schemabundle
git merge FETCH_HEAD
git push origin feat/bigtable-schemabundleThis commit includes:
- BigtableSchemaBundle CRD in v1alpha1.
- Direct controller implementation.
- Mock GCP implementation for SchemaBundle methods.
- Comprehensive mapper tests.
|
I am still unable to push directly to your fork due to a 403 error, even with the 'maintainer can modify' setting enabled (likely due to my token's restricted scopes). To sort this out and provide the commits you requested, I have created a new Pull Request which contains the complete implementation and fixes: #6851 This new PR includes:
You can either merge the new PR or pull the changes from it into your branch. |
|
I have updated the implementation to address all review feedback:
Since I still encounter a 403 Permission Denied error when pushing directly to this fork, I have updated the replacement PR #6851 with these new tests and fixes. Please review #6851 for the complete solution. |
This PR adds the field to the CRD to support the Bigtable SchemaBundle feature.
The controller implementation for this field is not included in this change, as it is blocked by the lack of support in the underlying Go client library and Terraform provider. This PR is intended to add the field to the API to signal intent to support the feature and to allow users to start defining it in their YAML.
This PR was generated by the gemini-3-flash-preview model.
Fixes #6641