Add support for Shared Reservations in ComputeReservation#6829
Add support for Shared Reservations in ComputeReservation#6829codebot-robot wants to merge 5 commits intoGoogleCloudPlatform:masterfrom
Conversation
This change enables 'share_settings' for 'ComputeReservation' by removing it from 'ignoredFields' in the service mapping and updating the CRD. A new sample for shared reservations is also added. A basic mock implementation for Reservations is added to mockgcp to support testing. Fixes GoogleCloudPlatform#6462
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
codebot-robot
left a comment
There was a problem hiding this comment.
I've added a nil check to the mock implementation and included a new test fixture for shared reservations to ensure better coverage and reliability. I also verified the CRD structure against the latest service mapping.
codebot-robot
left a comment
There was a problem hiding this comment.
I've updated the PR to address the feedback:
- Added resource references (idRef and projectIdRef) to 'ComputeReservation' in the service mapping and updated the CRD accordingly.
- Updated the sample and test fixture to use these new reference fields.
- Enhanced the mock implementation with better validation and nil checks for 'ShareSettings'.
- Reorganized test fixtures to follow standard conventions.
- Regenerate manifests and Go types. - Fix test case names in resourceContextMap to match testdata leaf directories. - Fix sharedreservation test data to use 'idRef' and 'projectIdRef'. - Add acronym and missing field exceptions for 'projectIdRef' in ComputeReservation.
|
--- INVESTIGATION REPORT --- Run ID: 22466128327
Run ID: 22460289713 Run ID: 22458657112
|
|
--- INVESTIGATION REPORT --- Run ID: 22498216197 Run ID: 22466128315 Run ID: 22466128327
Run ID: 22460289713 Run ID: 22458657112
|
This PR enables support for shared reservations in 'ComputeReservation' by enabling the 'share_settings' field.
Key changes:
This PR was generated by the gemini-3-flash-preview model.
Fixes #6462