feat(gkehub): support GKEHubScope and GKEHubNamespace#6843
Open
codebot-robot wants to merge 11 commits intoGoogleCloudPlatform:masterfrom
Open
feat(gkehub): support GKEHubScope and GKEHubNamespace#6843codebot-robot wants to merge 11 commits intoGoogleCloudPlatform:masterfrom
codebot-robot wants to merge 11 commits intoGoogleCloudPlatform:masterfrom
Conversation
This PR adds support for GKE Hub Scope and GKEHubNamespace resources using the Direct controller architecture. It includes: - API types and CRDs for GKEHubScope and GKEHubNamespace - Direct controllers for both resources - Mock implementation in mockgcp - Test fixtures for validation
- Fix string formatting verbs in gkehub controllers (govet) - Delete redundant duplicate protos from mockgcp/apis/google to resolve protoc shadowing errors - Remove conflicting generated proto file from mockgcp/third_party via fixup-third-party.sh - Run make gen-proto to cleanly regenerate mockgcp protos with correct copyright headers - Run dev/tasks/generate-resource-report to update documentation
- Fix fmt.Errorf format strings in GKEHub controllers. - Add missing 2026 copyright headers to service.proto and test fixtures. - Rename GKEHub test fixtures to be unique (gkehubscope-basic, gkehubnamespace-basic). - Improve GKEHubScope and GKEHubNamespace controllers to be idempotent. - Sync mockgcp dependencies.
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for GKE Hub Scope and GKEHubNamespace resources using the Direct controller architecture.
It addresses the following issues:
This is a replacement for #6519, which was stale and from a fork that was hard to update.
Summary of changes: