feat : Session Initialize() #567
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bectl-ai into session_persistance
Conflicts: go.mod Changes to be committed: modified: go.mod new file: pkg/sessions/session_test.go
…latform#518 now looks closed, also closes GoogleCloudPlatform#497
…rmat.sh" This reverts commit 123954a.
…ormat.sh" This reverts commit 325734a.
…/tasks/format.sh"" This reverts commit 68b0066.
…bectl-ai into session_persistance
…CloudPlatform#464 Ollama Session Init() implement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@noahlwest
In this pull request, I am putting a copy of the Gemini Initialize() logic for llamacpp.go and ollama.go so that users are not blocked and can keep working as we complete this as per all the current issues faced. If you feel that this should be on hold and only merged once completed ... then that's fine too
I haven't implemented any test cases for the same so that remains open which I will close shortly.
I haven't implemented any provider or agent specific functionality (e.g. the bedrock implementation doesn't support non-text messages)
I have already added similar Initialze() methods and also tested them with the Provider on Azure, OpenAI and Grok earlier which is part of #497 (i.e. it covers #459 #462 #465 )