Skip to content

ADK-vLLM code migration#1792

Merged
NimJay merged 4 commits intoGoogleCloudPlatform:mainfrom
fcabrera23:adk-vllm
Sep 19, 2025
Merged

ADK-vLLM code migration#1792
NimJay merged 4 commits intoGoogleCloudPlatform:mainfrom
fcabrera23:adk-vllm

Conversation

@fcabrera23
Copy link
Contributor

@fcabrera23 fcabrera23 commented Sep 18, 2025

Description

This PR migrated the code from the AI on GKE (tutorials-and-examples) repo -> https://github.com/ai-on-gke/tutorials-and-examples/tree/main/adk/llama/vllm to this repo for support for GKE docs.

This code will be used for the new doc titled: "Deploy an agentic AI application on GKE with the Agent Development Kit (ADK) and a self-hosted LLM"

Tasks

  • The contributing guide has been read and followed.
  • The samples added / modified have been fully tested.
  • Workflow files have been added / modified, if applicable.
  • Region tags have been properly added, if new samples.
  • Editable variables have been used, where applicable.
  • All dependencies are set to up-to-date versions, as applicable.
  • Merge this pull-request for me once it is approved.

Migrating code from the AI on GKE (tutorials-and-examples) repo -> https://github.com/ai-on-gke/tutorials-and-examples/tree/main/adk/llama/vllm
@fcabrera23 fcabrera23 requested a review from a team as a code owner September 18, 2025 17:49
@fcabrera23 fcabrera23 changed the title ADK-vLLM code migration. ADK-vLLM code migration Sep 18, 2025
Copy link
Collaborator

@alizaidis alizaidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bourgeoisor bourgeoisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved conditional to the comment I left. The rest looks good.

@fcabrera23
Copy link
Contributor Author

@bourgeoisor @alizaidis applied required changes

Copy link
Collaborator

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reviews (and approvals), @alizaidis & @bourgeoisor.
Merging since the pending comment thread has been resolved.

@NimJay NimJay merged commit 399f3b7 into GoogleCloudPlatform:main Sep 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants