Skip to content

implemented headless service example for whereami#1834

Merged
theemadnes merged 4 commits intoGoogleCloudPlatform:mainfrom
theemadnes:issue-1833
Dec 8, 2025
Merged

implemented headless service example for whereami#1834
theemadnes merged 4 commits intoGoogleCloudPlatform:mainfrom
theemadnes:issue-1833

Conversation

@theemadnes
Copy link
Member

Description

This PR adds a set of K8s YAML for whereami, so when you use gRPC mode, the backend service can be configured as a headless service.

Tasks

  • [ x] The contributing guide has been read and followed.
  • [ x] The samples added / modified have been fully tested.
  • Workflow files have been added / modified, if applicable.
  • Region tags have been properly added, if new samples.
  • [x ] Editable variables have been used, where applicable.
  • [x ] All dependencies are set to up-to-date versions, as applicable.
  • [ x] Merge this pull-request for me once it is approved.

@theemadnes theemadnes requested review from a team and yoshi-approver as code owners November 27, 2025 01:28
@snippet-bot
Copy link

snippet-bot bot commented Nov 27, 2025

Here is the summary of changes.

You are about to add 6 region tags.
You are about to delete 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@theemadnes theemadnes enabled auto-merge (squash) November 27, 2025 01:31
@theemadnes
Copy link
Member Author

#1833

@bourgeoisor
Copy link
Member

@theemadnes the header check is complaining about these:

quickstarts/whereami/k8s-grpc-clusterip-backend-overlay-example/cm-flag.yaml should have a copyright year of 2025
quickstarts/whereami/k8s-grpc-clusterip-backend-overlay-example/kustomization.yaml is missing a valid license header.
quickstarts/whereami/k8s-grpc-headless-backend-overlay-example/kustomization.yaml is missing a valid license header.
quickstarts/whereami/k8s-grpc-headless-backend-overlay-example/service-type.yaml should have a copyright year of 2025

@theemadnes
Copy link
Member Author

will fix this evening or this weekend

@theemadnes
Copy link
Member Author

@bourgeoisor should be good to go

Copy link
Member

@bourgeoisor bourgeoisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@theemadnes theemadnes merged commit b4227c6 into GoogleCloudPlatform:main Dec 8, 2025
4 checks passed
@theemadnes theemadnes deleted the issue-1833 branch January 17, 2026 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments