Skip to content

Commit 9cc210e

Browse files
authored
Use a separate network in TestAccContainerCluster_networkingModeRoutes (#15820)
1 parent 416e04c commit 9cc210e

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

mmv1/third_party/terraform/services/container/resource_container_cluster_test.go.tmpl

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,9 @@ func TestAccContainerCluster_resourceManagerTags(t *testing.T) {
177177
func TestAccContainerCluster_networkingModeRoutes(t *testing.T) {
178178
t.Parallel()
179179

180+
// separate shared network name because test requests a specific CIDR
181+
networkName := acctest.BootstrapSharedTestNetwork(t, "gke-cluster-moderoutes")
182+
subnetworkName := acctest.BootstrapSubnet(t, "gke-cluster-moderoutes", networkName)
180183
firstClusterName := fmt.Sprintf("tf-test-cluster-%s", acctest.RandString(t, 10))
181184
secondClusterName := fmt.Sprintf("tf-test-cluster-%s", acctest.RandString(t, 10))
182185
acctest.VcrTest(t, resource.TestCase{
@@ -185,7 +188,7 @@ func TestAccContainerCluster_networkingModeRoutes(t *testing.T) {
185188
CheckDestroy: testAccCheckContainerClusterDestroyProducer(t),
186189
Steps: []resource.TestStep{
187190
{
188-
Config: testAccContainerCluster_networkingModeRoutes(firstClusterName, secondClusterName),
191+
Config: testAccContainerCluster_networkingModeRoutes(firstClusterName, secondClusterName, networkName, subnetworkName),
189192
Check: resource.ComposeTestCheckFunc(
190193
resource.TestCheckResourceAttr("google_container_cluster.primary", "networking_mode", "ROUTES"),
191194
resource.TestCheckResourceAttr("google_container_cluster.secondary", "networking_mode", "ROUTES"), ),
@@ -7442,24 +7445,28 @@ resource "google_container_cluster" "primary" {
74427445
`, projectID, name, networkName, subnetworkName)
74437446
}
74447447

7445-
func testAccContainerCluster_networkingModeRoutes(firstName, secondName string) string {
7448+
func testAccContainerCluster_networkingModeRoutes(firstName, secondName, networkName, subnetworkName string) string {
74467449
return fmt.Sprintf(`
74477450
resource "google_container_cluster" "primary" {
74487451
name = "%s"
74497452
location = "us-central1-a"
74507453
initial_node_count = 1
74517454
networking_mode = "ROUTES"
7455+
network = "%s"
7456+
subnetwork = "%s"
74527457
deletion_protection = false
74537458
}
74547459

74557460
resource "google_container_cluster" "secondary" {
74567461
name = "%s"
74577462
location = "us-central1-a"
74587463
initial_node_count = 1
7464+
network = "%s"
7465+
subnetwork = "%s"
74597466
cluster_ipv4_cidr = "10.96.0.0/14"
74607467
deletion_protection = false
74617468
}
7462-
`, firstName, secondName)
7469+
`, firstName, networkName, subnetworkName, secondName, networkName, subnetworkName)
74637470
}
74647471

74657472
func testAccContainerCluster_misc(name, networkName, subnetworkName string) string {

0 commit comments

Comments
 (0)