resourceIdentity: testing generation; products n-z#15019
Closed
BBBmau wants to merge 2 commits intoGoogleCloudPlatform:FEATURE-BRANCH-resource-identity-generationfrom
Closed
resourceIdentity: testing generation; products n-z#15019BBBmau wants to merge 2 commits intoGoogleCloudPlatform:FEATURE-BRANCH-resource-identity-generationfrom
resourceIdentity: testing generation; products n-z#15019BBBmau wants to merge 2 commits intoGoogleCloudPlatform:FEATURE-BRANCH-resource-identity-generationfrom
Conversation
modular-magician
added
awaiting-approval
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Collaborator
Non-exercised tests🔴 Tests were added that are skipped in VCR:
Tests analyticsTotal tests: 3510 Click here to see the affected service packages
Action takenFound 754 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
modular-magician
added
awaiting-approval
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
BBBmau
force-pushed
the
mmv1/test-generation-q-z
branch
from
d505095 to
614d8c8
Compare
modular-magician
added
awaiting-approval
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Collaborator
Non-exercised tests🔴 Tests were added that are skipped in VCR:
Tests analyticsTotal tests: 3507 Click here to see the affected service packages
Action takenFound 751 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Collaborator
Tests analyticsTotal tests: 3062 Click here to see the affected service packages
Action takenFound 547 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
BBBmau
force-pushed
the
mmv1/test-generation-q-z
branch
from
614d8c8 to
5f8d60a
Compare
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Collaborator
Tests analyticsTotal tests: 3108 Click here to see the affected service packages
Action takenFound 453 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
…test-generation-q-z
BBBmau
changed the title
resourceIdentity: testing generation; products Q-ZresourceIdentity: testing generation; products n-z
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Collaborator
Tests analyticsTotal tests: 1226 Click here to see the affected service packages
Action takenFound 246 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Collaborator
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Several tests terminated during RECORDING mode. 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Collaborator
Author
|
/gcbrun |
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Collaborator
Tests analyticsTotal tests: 564 Click here to see the affected service packages
Action takenFound 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Collaborator
|
🔴 Tests failed during RECORDING mode: 🔴 Several tests terminated during RECORDING mode. 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Collaborator
Author
|
/gcbrun |
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Collaborator
Tests analyticsTotal tests: 1259 Click here to see the affected service packages
Action takenFound 16 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Collaborator
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Collaborator
Author
|
pinging to get these checked @shuyama1 once this one is approved ill create a PR that combines all products, we can then move into looking over what's needed to get this feature merged entirely |
shuyama1
approved these changes
Oct 2, 2025
Member
shuyama1
left a comment
shuyama1
left a comment
There was a problem hiding this comment.
Failures seem unrelated. Netapp ones should be resolved by syncing with the main branch
Member
nvm, I see it now. Generator is conditionally updated in each PR. Are you planning to sync the branch first before the combined testing PR |
Collaborator
Author
each PR is making a one line change on the template that was merged prior in order to speed up the VCR testing. the template originally added can be found here where we had it as just So really the only change we would need to do is to remove the one line that introduces the productName letter. we can't merge these because they would be updating the productName when the real change thats needed is to remove it entirely edit: here's the PR that would remove the productName check in generation: |
This was referenced Oct 3, 2025
Merged
Merged
|
This PR is approved and has been waiting for merge for 1 week. Is it ready to merge? Use the label |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.