resourceIdentity: remove productName character check#4572
Merged
Conversation
[upstream:53b0c9d1dfc6d0c4cf8b572a06ebc825a8634002] Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
requested review from
a team and
melinath
and removed request for
a team
modular-magician
merged commit 5778f3c
into
GoogleCloudPlatform:FEATURE-BRANCH-resource-identity-generation
1 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
originally we made the update to the test template in order to speed of the testing of VCR tests by separating it based on product name character. After running through them all in individual PRs we can now remove the conditional that prevents all the tests from being ran:
resourceIdentity: testing generation; products e-h magic-modules#15021resourceIdentity: testing generation; products i-m magic-modules#15020resourceIdentity: testing generation; products n-z magic-modules#15019The original PR that introduced the test template with no operation can be found here:
resourceIdentity: testing generation template magic-modules#14993Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.
Derived from GoogleCloudPlatform/magic-modules#15295