Skip to content

Conversation

@SamanthaMathews
Copy link

Add tags field to instance resource to allow setting tags on instance resources at creation time.
Part of b/364841739
release-note:none

filestore: added `tags` field to `filstore_instance` to allow setting tags for instances at creation time
The contents of this code are entirely owned by Google LLC in accordance with the agreement between Google LLC and the third party submitting this code into Google's open source repository

@google-cla
Copy link

google-cla bot commented Mar 24, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 24, 2025
@SamanthaMathews SamanthaMathews marked this pull request as ready for review May 21, 2025 14:33
@SamanthaMathews SamanthaMathews marked this pull request as draft May 21, 2025 14:34
@github-actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from roaks3 May 21, 2025 14:34
@roaks3
Copy link
Contributor

roaks3 commented May 22, 2025

Just to make it explicit: with this being a tags contribution and the PR being in draft mode, I'm assuming this isn't ready for review (or submission) yet. Please leave a comment if/when this is ready to be looked at.

@SamanthaMathews
Copy link
Author

Just to make it explicit: with this being a tags contribution and the PR being in draft mode, I'm assuming this isn't ready for review (or submission) yet. Please leave a comment if/when this is ready to be looked at.

I have CLA issues. This PR need not be submitted. I am getting help from someone without CLA issues to get the PR reviewed. This PR is for them to clone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants