Added support for NAT64 when configuring Router NAT #13522

matheusaleixo-cit · 2025-04-02T22:02:57Z

Adds sourceSubnetworkIpRangesToNat64 and nat64Subnetwork fields to compute RouterNat, allowing the support for public Router NAT services with NAT64 enabled.

Also adds dns64Config field to dns Policy, allowing the configuration of DNS64 server policies, required when using NAT64.

Fixes: #22116

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added `source_subnetwork_ip_ranges_to_nat64` and `nat64_subnetwork` fields  to `google_compute_router_nat` resource

dns: added `dns64_config` field  to `google_dns_policy` resource

… compute RouterNat; - Added dns64Config field to dns Policy;

github-actions · 2025-04-03T12:25:31Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2025-04-03T22:39:06Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 208 insertions(+))
google-beta provider: Diff ( 8 files changed, 515 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 48 insertions(+))

modular-magician · 2025-04-03T23:02:52Z

Tests analytics

Total tests: 1208
Passed tests: 1106
Skipped tests: 80
Affected tests: 22

Click here to see the affected service packages

compute

dns

Action taken

Found 22 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeRouterNatAddress_withAddressCountDecrease

TestAccComputeRouterNatAddress_withAddressRemoved

TestAccComputeRouterNatAddress_withAutoAllocateAndAddressRemoved

TestAccComputeRouterNatAddress_withNatIpsAndDrainNatIps

TestAccComputeRouterNat_AutoNetworkTier

TestAccComputeRouterNat_basic

TestAccComputeRouterNat_update

TestAccComputeRouterNat_withAddressCountDecrease

TestAccComputeRouterNat_withEndpointTypes

TestAccComputeRouterNat_withManualIpAndSubnetConfiguration

TestAccComputeRouterNat_withNat64Configuration

TestAccComputeRouterNat_withNatIpsAndDrainNatIps

TestAccComputeRouterNat_withNatRules

TestAccComputeRouterNat_withPortAllocationMethods

TestAccComputeRouterNat_withPrivateNat

TestAccComputeRouterNat_withPrivateNatAndEmptyAction

TestAccComputeRouterNat_withPrivateNatAndEmptyActionActiveRanges

TestAccComputeRouterNat_withPrivateNatAndRules

TestAccDataSourceGoogleComputeRouterNat_basic

TestAccDNSPolicy_dnsPolicyDns64

TestAccDNSPolicy_dnsPolicyMultiprojectExample

TestAccDNSRecordSet_routingPolicy

Get to know how VCR tests work

modular-magician · 2025-04-03T23:15:18Z

🟢 Tests passed during RECORDING mode:
TestAccComputeRouterNatAddress_withAddressCountDecrease [Debug log]
TestAccComputeRouterNatAddress_withAddressRemoved [Debug log]
TestAccComputeRouterNatAddress_withAutoAllocateAndAddressRemoved [Debug log]
TestAccComputeRouterNatAddress_withNatIpsAndDrainNatIps [Debug log]
TestAccComputeRouterNat_AutoNetworkTier [Debug log]
TestAccComputeRouterNat_basic [Debug log]
TestAccComputeRouterNat_update [Debug log]
TestAccComputeRouterNat_withAddressCountDecrease [Debug log]
TestAccComputeRouterNat_withEndpointTypes [Debug log]
TestAccComputeRouterNat_withManualIpAndSubnetConfiguration [Debug log]
TestAccComputeRouterNat_withNat64Configuration [Debug log]
TestAccComputeRouterNat_withNatIpsAndDrainNatIps [Debug log]
TestAccComputeRouterNat_withNatRules [Debug log]
TestAccComputeRouterNat_withPortAllocationMethods [Debug log]
TestAccComputeRouterNat_withPrivateNat [Debug log]
TestAccComputeRouterNat_withPrivateNatAndEmptyAction [Debug log]
TestAccComputeRouterNat_withPrivateNatAndEmptyActionActiveRanges [Debug log]
TestAccComputeRouterNat_withPrivateNatAndRules [Debug log]
TestAccDNSPolicy_dnsPolicyDns64 [Debug log]
TestAccDataSourceGoogleComputeRouterNat_basic [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccDNSPolicy_dnsPolicyMultiprojectExample [Error message] [Debug log]
TestAccDNSRecordSet_routingPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

mmv1/products/dns/Policy.yaml

rileykarson · 2025-04-04T18:23:54Z

mmv1/third_party/terraform/services/compute/resource_compute_router_nat_test.go.tmpl

+
+	acctest.VcrTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderBetaFactories(t),


Suggested change

ProtoV5ProviderFactories: acctest.ProtoV5ProviderBetaFactories(t),

ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),

& remove google-beta from test configs- the implicit google provider will be the beta provider inside these tests. We only use the specific beta factory for example tests so the docs use the beta provider!

- Removed google-beta provider usage in Nat64Config test;

github-actions · 2025-04-09T09:43:23Z

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2025-04-11T09:42:46Z

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2025-04-18T09:42:43Z

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

modular-magician · 2025-04-23T17:53:41Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 209 insertions(+))
google-beta provider: Diff ( 8 files changed, 504 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 48 insertions(+))

modular-magician · 2025-04-23T18:17:46Z

Tests analytics

Total tests: 1224
Passed tests: 1139
Skipped tests: 85
Affected tests: 0

Click here to see the affected service packages

compute

dns

🟢 All tests passed!

View the build log

rileykarson · 2025-04-23T23:08:02Z

mmv1/products/dns/Policy.yaml

+    type: NestedObject
+    default_from_api: true
+    description: Configurations related to DNS64 for this Policy.
+    properties:


Should these subfields be required or would it be valid to write dns64_config {}? The configurations below seem like we could start w/ required.

I did some testing and using dns64_config {} causes a permadiff, so I guess we should set it as required.
Setting dns64_config { scope {} } seems to be functional when creating a new resource and when updating existing dns64_config values, so maybe we can keep allQueries as optional?

mmv1/products/compute/RouterNat.yaml

- Added update test step to TestAccDNSPolicy_dnsPolicyDns64;

github-actions · 2025-04-30T09:43:34Z

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2025-05-02T09:43:06Z

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2025-05-09T09:43:31Z

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2025-05-16T09:43:57Z

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

modular-magician · 2025-05-20T20:50:28Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 546 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 8 files changed, 546 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 48 insertions(+))

modular-magician · 2025-05-20T21:17:45Z

Tests analytics

Total tests: 1247
Passed tests: 1162
Skipped tests: 84
Affected tests: 1

Click here to see the affected service packages

compute

dns

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDNSPolicy_dnsPolicyDns64

Get to know how VCR tests work

modular-magician · 2025-05-20T21:19:22Z

🟢 Tests passed during RECORDING mode:
TestAccDNSPolicy_dnsPolicyDns64 [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

github-actions · 2025-05-23T09:43:29Z

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 4 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

rileykarson

LGTM, thanks!

…orm#13522)

- Added sourceSubnetworkIpRangesToNat64 and nat64Subnetwork fields to…

fc7d484

… compute RouterNat; - Added dns64Config field to dns Policy;

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 2, 2025

matheusaleixo-cit marked this pull request as ready for review April 3, 2025 12:24

github-actions bot requested a review from rileykarson April 3, 2025 12:25

modular-magician added service/cloud-dns service/compute-nat and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 3, 2025

rileykarson reviewed Apr 4, 2025

View reviewed changes

- Added default_from_api property to dns64Config field;

f91cd7c

- Removed google-beta provider usage in Nat64Config test;

github-actions bot requested a review from rileykarson April 4, 2025 20:10

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 4, 2025

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 23, 2025

rileykarson reviewed Apr 23, 2025

View reviewed changes

matheusaleixo-cit added 2 commits April 24, 2025 17:25

Merge branch 'main' into add-new-nat64-support-for-compute-router-nat

0a28bc0

- Configured dns64Config.scope field as required;

7e68c99

- Added update test step to TestAccDNSPolicy_dnsPolicyDns64;

github-actions bot requested a review from rileykarson April 25, 2025 20:45

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 25, 2025

Merge branch 'main' into add-new-nat64-support-for-compute-router-nat

c95f143

matheusaleixo-cit added 3 commits May 15, 2025 11:22

Merge branch 'main' into add-new-nat64-support-for-compute-router-nat

7d58c0f

- Promoted new NAT64 fields to GA;

0fd4a64

- lint fix

3daaad4

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label May 20, 2025

rileykarson approved these changes May 29, 2025

View reviewed changes

rileykarson added this pull request to the merge queue May 29, 2025

Merged via the queue into GoogleCloudPlatform:main with commit 00ab640 May 29, 2025
27 checks passed

NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Jun 5, 2025

Added support for NAT64 when configuring Router NAT (GoogleCloudPlatf…

818c056

…orm#13522)

sahil-mahajan-google pushed a commit to sahil-mahajan-google/magic-modules that referenced this pull request Jun 6, 2025

Added support for NAT64 when configuring Router NAT (GoogleCloudPlatf…

51e91ae

…orm#13522)

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025

Added support for NAT64 when configuring Router NAT (GoogleCloudPlatf…

ac9152f

…orm#13522)

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025

Added support for NAT64 when configuring Router NAT (GoogleCloudPlatf…

aa7c8a9

…orm#13522)

jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025

Added support for NAT64 when configuring Router NAT (GoogleCloudPlatf…

5c00609

…orm#13522)

matheusaleixo-cit deleted the add-new-nat64-support-for-compute-router-nat branch July 16, 2025 20:31

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025

Added support for NAT64 when configuring Router NAT (GoogleCloudPlatf…

db8bc7b

…orm#13522)

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025

Added support for NAT64 when configuring Router NAT (GoogleCloudPlatf…

b8d7ea4

…orm#13522)

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025

Added support for NAT64 when configuring Router NAT (GoogleCloudPlatf…

eae58ee

…orm#13522)

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025

Added support for NAT64 when configuring Router NAT (GoogleCloudPlatf…

13c752d

…orm#13522)

NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Sep 4, 2025

Added support for NAT64 when configuring Router NAT (GoogleCloudPlatf…

4025454

…orm#13522)

	ProtoV5ProviderFactories: acctest.ProtoV5ProviderBetaFactories(t),
	ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),

Added support for NAT64 when configuring Router NAT #13522

Added support for NAT64 when configuring Router NAT #13522

Uh oh!

Conversation

matheusaleixo-cit commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 3, 2025

Uh oh!

modular-magician commented Apr 3, 2025

Diff report

Uh oh!

modular-magician commented Apr 3, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 3, 2025

Uh oh!

Uh oh!

rileykarson Apr 4, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 9, 2025

Uh oh!

github-actions bot commented Apr 11, 2025

Uh oh!

github-actions bot commented Apr 18, 2025

Uh oh!

modular-magician commented Apr 23, 2025

Diff report

Uh oh!

modular-magician commented Apr 23, 2025

Tests analytics

Uh oh!

rileykarson Apr 23, 2025

Choose a reason for hiding this comment

Uh oh!

matheusaleixo-cit Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Apr 30, 2025

Uh oh!

github-actions bot commented May 2, 2025

Uh oh!

github-actions bot commented May 9, 2025

Uh oh!

github-actions bot commented May 16, 2025

Uh oh!

modular-magician commented May 20, 2025

Diff report

Uh oh!

modular-magician commented May 20, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented May 20, 2025

Uh oh!

github-actions bot commented May 23, 2025

Uh oh!

rileykarson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

matheusaleixo-cit commented Apr 2, 2025 •

edited

Loading