Fixed ServiceAttachment target_service region/location inconsistency when referencing a Secure Web Proxy on creation

[matheusaleixo-cit]

Adds changes to the ParseRegionalFieldValue helper function to support resource values that uses locations.

This fixes ServiceAttachment target_service validation failing on creation when referencing a Secure Web Proxy without having region configured at the provider level.

Fixes: #22183

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: fixed validation for `target_service` field in `google_compute_service_attachment` resource causing issues when targeting a `google_network_services_gateway` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 24 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 24 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 4902
Passed tests: 4442
Skipped tests: 455
Affected tests: 5

Click here to see the affected service packages

All service packages are affected

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccAccessContextManager
• TestAccCloudbuildWorkerPool_basic
• TestAccDataSourceGoogleGkeHubFeature_basic
• TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample
• TestAccLoggingFolderSettings_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccLoggingFolderSettings_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode:
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 24 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 24 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 24 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 4933
Passed tests: 4466
Skipped tests: 460
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccAccessContextManager
• TestAccCloudIdentityGroup
• TestAccCloudbuildWorkerPool_basic
• TestAccDataSourceGoogleGkeHubFeature_basic
• TestAccDiscoveryEngineChatEngine_discoveryengineChatEngineExistingDialogflowAgentExample
• TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample
• TestAccLoggingFolderSettings_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccLoggingFolderSettings_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccDiscoveryEngineChatEngine_discoveryengineChatEngineExistingDialogflowAgentExample [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Several tests terminated during RECORDING mode.

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 24 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 24 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 24 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 4953
Passed tests: 4489
Skipped tests: 460
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccCloudbuildWorkerPool_basic
• TestAccDataSourceGoogleGkeHubFeature_basic
• TestAccDiscoveryEngineChatEngine_discoveryengineChatEngineExistingDialogflowAgentExample
• TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode:
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccDiscoveryEngineChatEngine_discoveryengineChatEngineExistingDialogflowAgentExample [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[trodge]

/gcbrun

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccLoggingFolderSettings_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]
TestAccLoggingFolderSettings_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample [Error message] [Debug log]
TestAccComputeFirewallPolicyWithRules_update [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 4 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[trodge]

The helper change looks good to me, let's go with that option.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 22 insertions(+))
google-beta provider: Diff ( 1 file changed, 22 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))

[modular-magician]

Tests analytics

Total tests: 5056
Passed tests: 4584
Skipped tests: 469
Affected tests: 3

Click here to see the affected service packages

All service packages are affected

#### Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccAccessContextManager
• TestAccDataSourceGoogleGkeHubFeature_basic
• TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test