Add PSC fields to Filestore instance in beta

[osela]

PSC configuration support for Filestore.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

filestore: added PSC fields to `google_filestore_instance` (beta)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 26 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 4 files changed, 219 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 41 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_filestore_instance (25 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_filestore_instance" "primary" {
  file_shares {
    nfs_export_options {
      network = # value needed
    }
  }
  networks {
    psc_config {
      endpoint_project = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 18
Passed tests: 17
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• filestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccFilestoreInstance_psc

Get to know how VCR tests work

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 26 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 4 files changed, 219 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 41 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_filestore_instance (25 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_filestore_instance" "primary" {
  file_shares {
    nfs_export_options {
      network = # value needed
    }
  }
  networks {
    psc_config {
      endpoint_project = # value needed
    }
  }
}

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccFilestoreInstance_psc [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 18
Passed tests: 17
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• filestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccFilestoreInstance_psc

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccFilestoreInstance_psc [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 26 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 4 files changed, 224 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 41 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_filestore_instance (25 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_filestore_instance" "primary" {
  file_shares {
    nfs_export_options {
      network = # value needed
    }
  }
  networks {
    psc_config {
      endpoint_project = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 18
Passed tests: 17
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• filestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccFilestoreInstance_psc

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccFilestoreInstance_psc [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[osela]

/gcbrun

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 26 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 4 files changed, 224 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 41 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_filestore_instance (25 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_filestore_instance" "primary" {
  file_shares {
    nfs_export_options {
      network = # value needed
    }
  }
  networks {
    psc_config {
      endpoint_project = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 18
Passed tests: 17
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• filestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccFilestoreInstance_psc

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccFilestoreInstance_psc [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 26 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 4 files changed, 224 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 41 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_filestore_instance (25 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_filestore_instance" "primary" {
  file_shares {
    nfs_export_options {
      network = # value needed
    }
  }
  networks {
    psc_config {
      endpoint_project = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 18
Passed tests: 17
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• filestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccFilestoreInstance_psc

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccFilestoreInstance_psc [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 26 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 4 files changed, 226 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 41 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_filestore_instance (25 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_filestore_instance" "primary" {
  file_shares {
    nfs_export_options {
      network = # value needed
    }
  }
  networks {
    psc_config {
      endpoint_project = # value needed
    }
  }
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 26 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 4 files changed, 226 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 41 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_filestore_instance (25 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_filestore_instance" "primary" {
  file_shares {
    nfs_export_options {
      network = # value needed
    }
  }
  networks {
    psc_config {
      endpoint_project = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 18
Passed tests: 17
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• filestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccFilestoreInstance_psc

Get to know how VCR tests work

[roaks3]

LGTM, just need to see if it's viable to add an update test

[roaks3]

So normally for mutable fields we expect to see a test validating that behavior. Is there some limitation here? I know PSC setup can be relatively involved.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 24 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 4 files changed, 271 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 41 insertions(+))

[modular-magician]

Tests analytics

Total tests: 19
Passed tests: 18
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• filestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccFilestoreInstance_nfsExportOptionsNetwork_update

Get to know how VCR tests work

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 24 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 4 files changed, 272 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 41 insertions(+))

[modular-magician]

Tests analytics

Total tests: 19
Passed tests: 18
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• filestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccFilestoreInstance_nfsExportOptionsNetwork_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccFilestoreInstance_nfsExportOptionsNetwork_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccFilestoreInstance_nfsExportOptionsNetwork_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 24 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 4 files changed, 274 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 41 insertions(+))

[modular-magician]

Tests analytics

Total tests: 19
Passed tests: 19
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• filestore

🟢 All tests passed!

View the build log

[github-actions]

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.