Skip to content

Terraform support for Category and Term Resources#13923

Merged
SirGitsalot merged 77 commits intoGoogleCloudPlatform:mainfrom
Sachin-Rungta:terraform-category
May 16, 2025
Merged

Terraform support for Category and Term Resources#13923
SirGitsalot merged 77 commits intoGoogleCloudPlatform:mainfrom
Sachin-Rungta:terraform-category

Conversation

@Sachin-Rungta
Copy link
Copy Markdown
Member

@Sachin-Rungta Sachin-Rungta commented May 13, 2025

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_dataplex_glossary_category`
`google_dataplex_glossary_term`

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 2006 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 11 files changed, 2006 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 216 insertions(+))
Open in Cloud Shell: Diff ( 16 files changed, 456 insertions(+))

Multiple resources added

This PR adds multiple new resources: google_dataplex_glossary_category, google_dataplex_glossary_term. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 56
Passed tests: 54
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • dataplex

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataplexGlossaryCategory_update
  • TestAccDataplexGlossaryTerm_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataplexGlossaryCategory_update [Error message] [Debug log]
TestAccDataplexGlossaryTerm_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 56
Passed tests: 54
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • dataplex

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataplexGlossaryCategory_update
  • TestAccDataplexGlossaryTerm_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 2006 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 11 files changed, 2006 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 216 insertions(+))
Open in Cloud Shell: Diff ( 16 files changed, 456 insertions(+))

Multiple resources added

This PR adds multiple new resources: google_dataplex_glossary_category, google_dataplex_glossary_term. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataplexGlossaryCategory_update [Error message] [Debug log]
TestAccDataplexGlossaryTerm_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 56
Passed tests: 54
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • dataplex

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataplexGlossaryCategory_update
  • TestAccDataplexGlossaryTerm_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataplexGlossaryCategory_update [Error message] [Debug log]
TestAccDataplexGlossaryTerm_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 2010 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 11 files changed, 2010 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 216 insertions(+))
Open in Cloud Shell: Diff ( 16 files changed, 456 insertions(+))

Multiple resources added

This PR adds multiple new resources: google_dataplex_glossary_category, google_dataplex_glossary_term. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 56
Passed tests: 54
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • dataplex

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataplexGlossaryCategory_update
  • TestAccDataplexGlossaryTerm_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataplexGlossaryCategory_update [Error message] [Debug log]
TestAccDataplexGlossaryTerm_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 2016 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 13 files changed, 2016 insertions(+), 8 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 216 insertions(+))
Open in Cloud Shell: Diff ( 16 files changed, 456 insertions(+))

Multiple resources added

This PR adds multiple new resources: google_dataplex_glossary_category, google_dataplex_glossary_term. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 56
Passed tests: 54
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • dataplex

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataplexGlossaryCategory_update
  • TestAccDataplexGlossaryTerm_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataplexGlossaryCategory_update [Debug log]
TestAccDataplexGlossaryTerm_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@SirGitsalot SirGitsalot added this pull request to the merge queue May 16, 2025
Merged via the queue into GoogleCloudPlatform:main with commit fde094f May 16, 2025
27 checks passed
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 20, 2025
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Jun 5, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

override-multiple-resources Allow a PR to contain multiple new resources service/dataplex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants