Add fields to support for configuring Class ALB migration feature. #13926

ahmed-laiq · 2025-05-13T14:34:16Z

Add Terraform support for configuring Classic ALB migration feature. The support is added for the global backend-service and global forwarding rule. This feature allows gradual and controlled migration to the External Managed LB from Classic LB. The global forwarding rule config changes applies to all the backend bucket attached to the forwarding rule.

Fixes: hashicorp/terraform-provider-google#22760

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added `external_managed_migration_state` and `external_managed_migration_testing_percentage` to `google_compute_backend_service` resource.

compute: added `external_managed_backend_bucket_migration_state` and `external_managed_backend_bucket_migration_testing_percentage` to `google_compute_global_forwarding_rule` resource.

compute: added update support for `load_balancing_scheme` in `google_compute_backend_service` and `google_compute_global_forwarding_rule` resources to allow migrating between classic and global external ALB

github-actions · 2025-05-13T14:35:42Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2025-05-13T14:46:56Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 506 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 8 files changed, 506 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 40 insertions(+))

modular-magician · 2025-05-13T15:09:33Z

Tests analytics

Total tests: 1189
Passed tests: 1101
Skipped tests: 84
Affected tests: 4

Click here to see the affected service packages

compute

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeBackendService_updateCanaryMigration

TestAccComputeBackendService_withBackendAndPreference

TestAccComputeBackendService_withLogConfig

TestAccComputeGlobalForwardingRule_updateCanaryMigration

Get to know how VCR tests work

modular-magician · 2025-05-13T15:26:45Z

🟢 Tests passed during RECORDING mode:
TestAccComputeBackendService_updateCanaryMigration [Debug log]
TestAccComputeGlobalForwardingRule_updateCanaryMigration [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccComputeBackendService_withBackendAndPreference [Error message] [Debug log]
TestAccComputeBackendService_withLogConfig [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

…oad balancing scheme is mutable.

modular-magician · 2025-05-13T17:56:41Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 521 insertions(+), 12 deletions(-))
google-beta provider: Diff ( 8 files changed, 521 insertions(+), 12 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 40 insertions(+))

modular-magician · 2025-05-13T18:23:29Z

Tests analytics

Total tests: 1189
Passed tests: 1103
Skipped tests: 84
Affected tests: 2

Click here to see the affected service packages

compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeBackendService_withBackendAndPreference

TestAccComputeBackendService_withLogConfig

Get to know how VCR tests work

modular-magician · 2025-05-13T18:39:31Z

🟢 Tests passed during RECORDING mode:
TestAccComputeBackendService_withBackendAndPreference [Debug log]
TestAccComputeBackendService_withLogConfig [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

rileykarson

Generally looks good- just a few comments on tests.

mmv1/third_party/terraform/services/compute/resource_compute_backend_service_test.go.tmpl

rileykarson · 2025-05-13T18:35:48Z

mmv1/third_party/terraform/services/compute/resource_compute_backend_service_test.go.tmpl

 			},
 			{
-				Config: testAccComputeBackendService_withLogConfig3(serviceName, checkName, "INCLUDE_ALL_OPTIONAL", true),
+				Config: testAccComputeBackendService_withLogConfig3(serviceName2, checkName2, "INCLUDE_ALL_OPTIONAL", true),


Same as above- let's break the different loadBalancingSchemes into separate test cases.

mmv1/third_party/terraform/services/compute/resource_compute_backend_service_test.go.tmpl

rileykarson · 2025-05-13T18:41:21Z

mmv1/third_party/terraform/services/compute/resource_compute_backend_service_test.go.tmpl

+			Config: testAccComputeBackendService_withCanaryMigration(
+					serviceName, checkName, "updated-to-prepare", "PREPARE"),


Suggested change

Config: testAccComputeBackendService_withCanaryMigration(

serviceName, checkName, "updated-to-prepare", "PREPARE"),

Config: testAccComputeBackendService_withCanaryMigration( serviceName, checkName, "updated-to-prepare", "PREPARE"),

ConfigPlanChecks: resource.ConfigPlanChecks{

PreApply: []plancheck.PlanCheck{

plancheck.ExpectResourceAction("google_compute_backend_service.foobar", plancheck.ResourceActionUpdate),

},

},

This is optional, but you could add the following to each Config step after the first to ensure that we update the resource rather than recreate it. We need to do that automatically in the future!

mmv1/third_party/terraform/services/compute/resource_compute_backend_service_test.go.tmpl

.../third_party/terraform/services/compute/resource_compute_global_forwarding_rule_test.go.tmpl

Apply suggestions from code review Co-authored-by: Riley Karson <[email protected]>

modular-magician · 2025-05-13T23:22:22Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 617 insertions(+), 14 deletions(-))
google-beta provider: Diff ( 8 files changed, 617 insertions(+), 14 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 40 insertions(+))

modular-magician · 2025-05-13T23:27:09Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 617 insertions(+), 14 deletions(-))
google-beta provider: Diff ( 8 files changed, 617 insertions(+), 14 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 40 insertions(+))

modular-magician · 2025-05-13T23:48:36Z

Tests analytics

Total tests: 1192
Passed tests: 1103
Skipped tests: 84
Affected tests: 5

Click here to see the affected service packages

compute

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeBackendService_withBackendAndPreferenceExternalManaged

TestAccComputeBackendService_withBackendAndPreferenceInternalManaged

TestAccComputeBackendService_withBackendAndPreferenceInternalSelfManaged

TestAccComputeBackendService_withLogConfig

TestAccComputeBackendService_withLogConfigMode

Get to know how VCR tests work

modular-magician · 2025-05-13T23:53:03Z

Tests analytics

Total tests: 1192
Passed tests: 1103
Skipped tests: 84
Affected tests: 5

Click here to see the affected service packages

compute

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeBackendService_withBackendAndPreferenceExternalManaged

TestAccComputeBackendService_withBackendAndPreferenceInternalManaged

TestAccComputeBackendService_withBackendAndPreferenceInternalSelfManaged

TestAccComputeBackendService_withLogConfig

TestAccComputeBackendService_withLogConfigMode

Get to know how VCR tests work

modular-magician · 2025-05-13T23:56:53Z

🟢 Tests passed during RECORDING mode:
TestAccComputeBackendService_withBackendAndPreferenceExternalManaged [Debug log]
TestAccComputeBackendService_withBackendAndPreferenceInternalManaged [Debug log]
TestAccComputeBackendService_withBackendAndPreferenceInternalSelfManaged [Debug log]
TestAccComputeBackendService_withLogConfig [Debug log]
TestAccComputeBackendService_withLogConfigMode [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2025-05-14T00:00:29Z

🟢 Tests passed during RECORDING mode:
TestAccComputeBackendService_withBackendAndPreferenceExternalManaged [Debug log]
TestAccComputeBackendService_withBackendAndPreferenceInternalManaged [Debug log]
TestAccComputeBackendService_withBackendAndPreferenceInternalSelfManaged [Debug log]
TestAccComputeBackendService_withLogConfig [Debug log]
TestAccComputeBackendService_withLogConfigMode [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

rileykarson

LGTM, thanks!

mmv1/third_party/terraform/services/compute/resource_compute_backend_service_test.go.tmpl

rileykarson

LGTM, thanks!

…oogleCloudPlatform#13926) Co-authored-by: Riley Karson <[email protected]>

Add fields to support for configuring Class ALB migration feature.

1ff7f59

github-actions bot requested a review from rileykarson May 13, 2025 14:35

modular-magician added the service/compute-l7-load-balancer label May 13, 2025

Fixes existing tests to create new backend-service resource because l…

212f585

…oad balancing scheme is mutable.

rileykarson reviewed May 13, 2025

View reviewed changes

Fixes the suggestions of the code review.

56b4b68

github-actions bot requested a review from rileykarson May 13, 2025 23:10

Apply suggestions from code review

3c54379

Apply suggestions from code review Co-authored-by: Riley Karson <[email protected]>

rileykarson approved these changes May 14, 2025

View reviewed changes

mmv1/third_party/terraform/services/compute/resource_compute_backend_service_test.go.tmpl Show resolved Hide resolved

mmv1/third_party/terraform/services/compute/resource_compute_backend_service_test.go.tmpl Show resolved Hide resolved

rileykarson approved these changes May 14, 2025

View reviewed changes

rileykarson added this pull request to the merge queue May 14, 2025

Merged via the queue into GoogleCloudPlatform:main with commit c709083 May 14, 2025
23 checks passed

hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request May 14, 2025

Add fields to support for configuring Class ALB migration feature. (G…

1ba2aa4

…oogleCloudPlatform#13926) Co-authored-by: Riley Karson <[email protected]>

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 20, 2025

Add fields to support for configuring Class ALB migration feature. (G…

95668a1

…oogleCloudPlatform#13926) Co-authored-by: Riley Karson <[email protected]>

NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Jun 5, 2025

Add fields to support for configuring Class ALB migration feature. (G…

27324ea

…oogleCloudPlatform#13926) Co-authored-by: Riley Karson <[email protected]>

jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025

Add fields to support for configuring Class ALB migration feature. (G…

c4d30a4

…oogleCloudPlatform#13926) Co-authored-by: Riley Karson <[email protected]>

NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Sep 4, 2025

Add fields to support for configuring Class ALB migration feature. (G…

1303e90

…oogleCloudPlatform#13926) Co-authored-by: Riley Karson <[email protected]>

		Config: testAccComputeBackendService_withCanaryMigration(
		serviceName, checkName, "updated-to-prepare", "PREPARE"),

-			Config: testAccComputeBackendService_withCanaryMigration(
-					serviceName, checkName, "updated-to-prepare", "PREPARE"),
+			Config: testAccComputeBackendService_withCanaryMigration(					serviceName, checkName, "updated-to-prepare", "PREPARE"),
+			ConfigPlanChecks: resource.ConfigPlanChecks{
+				PreApply: []plancheck.PlanCheck{
+					plancheck.ExpectResourceAction("google_compute_backend_service.foobar", plancheck.ResourceActionUpdate),
+				},
+			},

Add fields to support for configuring Class ALB migration feature. #13926

Add fields to support for configuring Class ALB migration feature. #13926

Uh oh!

Conversation

ahmed-laiq commented May 13, 2025 • edited by rileykarson Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 13, 2025

Uh oh!

modular-magician commented May 13, 2025

Diff report

Uh oh!

modular-magician commented May 13, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented May 13, 2025

Uh oh!

modular-magician commented May 13, 2025

Diff report

Uh oh!

modular-magician commented May 13, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented May 13, 2025

Uh oh!

rileykarson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rileykarson May 13, 2025

Choose a reason for hiding this comment

Uh oh!

ahmed-laiq May 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rileykarson May 13, 2025

Choose a reason for hiding this comment

Uh oh!

ahmed-laiq May 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

modular-magician commented May 13, 2025

Diff report

Uh oh!

modular-magician commented May 13, 2025

Diff report

Uh oh!

modular-magician commented May 13, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented May 13, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented May 13, 2025

Uh oh!

modular-magician commented May 14, 2025

Uh oh!

rileykarson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rileykarson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

ahmed-laiq commented May 13, 2025 •

edited by rileykarson

Loading