Skip to content

Conversation

@rwhogg
Copy link
Contributor

@rwhogg rwhogg commented May 13, 2025

Release Note Template for Downstream PRs (will be copied)

firestore: deprecated `deletion_policy` field of `google_firestore_database` resource

@github-actions github-actions bot requested a review from slevenick May 13, 2025 19:58
@github-actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@rwhogg rwhogg force-pushed the deprecate-deletion-policy branch from fcb674e to 7f26c25 Compare May 13, 2025 19:58
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 3 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 3 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 3 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 3 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 25
Passed tests: 25
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • firestore

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 25
Passed tests: 25
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • firestore

🟢 All tests passed!

View the build log

@slevenick slevenick added this pull request to the merge queue May 13, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 181fcd4 May 13, 2025
21 checks passed
@rwhogg rwhogg deleted the deprecate-deletion-policy branch May 13, 2025 21:41
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request May 14, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 20, 2025
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Jun 5, 2025
jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants