Added check for multiple new resources in one PR#13937
Added check for multiple new resources in one PR#13937melinath merged 4 commits intoGoogleCloudPlatform:mainfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
|
Have you tested this on any outstanding PRs as a PoC? |
|
oh nevermind I see you are now |
|
yeah, sorry for the delay on that! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_apihub_host_project_registration2" "primary" {
gcp_project = # value needed
host_project_registration_id = # value needed
location = # value needed
}
Resource: resource "google_apihub_host_project_registration3" "primary" {
gcp_project = # value needed
host_project_registration_id = # value needed
location = # value needed
}
Multiple resources addedThis PR adds multiple new resources: |
Tests analyticsTotal tests: 1 Click here to see the affected service packages
🟢 All tests passed! View the build log |
This reverts commit 1566bb9.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
99af163
Fixed hashicorp/terraform-provider-google#19824
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.