Skip to content

Conversation

@melinath
Copy link
Member

Fixed hashicorp/terraform-provider-google#19824

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician

This comment was marked as outdated.

@melinath melinath requested a review from ScottSuarez May 13, 2025 21:53
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@ScottSuarez
Copy link
Contributor

Have you tested this on any outstanding PRs as a PoC?

@ScottSuarez
Copy link
Contributor

oh nevermind I see you are now

@melinath
Copy link
Member Author

yeah, sorry for the delay on that!

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 788 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 788 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 142 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_apihub_host_project_registration2 (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_apihub_host_project_registration2" "primary" {
  gcp_project                  = # value needed
  host_project_registration_id = # value needed
  location                     = # value needed
}

Resource: google_apihub_host_project_registration3 (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_apihub_host_project_registration3" "primary" {
  gcp_project                  = # value needed
  host_project_registration_id = # value needed
  location                     = # value needed
}

Multiple resources added

This PR adds multiple new resources: google_apihub_host_project_registration2, google_apihub_host_project_registration3. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1
Passed tests: 1
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • apihub

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@melinath melinath added this pull request to the merge queue May 14, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 99af163 May 14, 2025
21 checks passed
@melinath melinath deleted the disallow-multiple-resources branch May 14, 2025 16:00
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request May 14, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 20, 2025
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Jun 5, 2025
jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add PR size to reviewer assignment comment (and warn on large PRs)

3 participants