Add workload identity pool managed identity.#14048
Add workload identity pool managed identity.#14048zli82016 merged 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 37 Click here to see the affected service packages
Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🟢 All tests passed! |
a43c0d9 to
84618dd
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 37 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🟢 All tests passed! |
|
Hi @liminw @kenmccracken-google, please review the following generated documentation: How to view the rendered documentation?
|
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi @zli82016, thanks for reviewing this PR! If you got time, there's a problem I was hoping you can answer. Even though all the checks have passed in the CI, all the acceptance tests had been skipped when I ran the === NAME TestAccIAMBetaWorkloadIdentityPoolManagedIdentity_iamWorkloadIdentityPoolManagedIdentityBasicExample
envvar_utils.go:263: Environment variable GOOGLE_IDENTITY_USER is not set
--- SKIP: TestAccIAMBetaWorkloadIdentityPoolManagedIdentity_iamWorkloadIdentityPoolManagedIdentityBasicExample (70.59s)I didn't see these messages during my previous PRs (#13814, #13920). After some digging on myself, I suspect this message stemmed from:
My questions are:
Thank you so much for your help! |
84618dd to
17e74da
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 37 Click here to see the affected service packages
View the build log |
|
|
You can output the test logs to a file to check that if the test is run or not. For example, use the similar command |
Thanks for the answer!
Got it. Will do next time. |
5c95074
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.