-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Enforce id validation for WorkloadIdentityPool Managed Identity #14126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce id validation for WorkloadIdentityPool Managed Identity #14126
Conversation
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 37 Click here to see the affected service packages
Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🟢 All tests passed! |
|
@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
roaks3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable consider the context, noting that new validation could technically impact some existing configs, but it seems unlikely that there would be values failing this validation while succeeding previously
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.
Add back ID validation on WorkloadIdentityPool Managed Identity. Context: #14110 (comment)