Enable updating directory service config for Filestore instance

[michaeltur3]

Directory Services configuration updating support for Filestore.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

filestore: add support for updating `directory_services` fields in place in `google_filestore_instance`

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 317 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 72 insertions(+), 14 deletions(-))

[modular-magician]

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccFilestoreInstance_directoryServices

Tests analytics

Total tests: 19
Passed tests: 18
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• filestore

#### Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccFilestoreInstance_directoryServices

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccFilestoreInstance_directoryServices [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 319 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 61 insertions(+), 7 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 197 insertions(+))

[modular-magician]

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccFilestoreInstance_directoryServices

Tests analytics

Total tests: 19
Passed tests: 18
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• filestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccFilestoreInstance_directoryServices

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccFilestoreInstance_directoryServices [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 323 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 72 insertions(+), 14 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 197 insertions(+))

[modular-magician]

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccFilestoreInstance_directoryServices

Tests analytics

Total tests: 19
Passed tests: 18
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• filestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccFilestoreInstance_directoryServices

Get to know how VCR tests work

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 324 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 73 insertions(+), 14 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 197 insertions(+))

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccFilestoreInstance_directoryServices [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Click here to see Test Coverage Metrics

• github.com/hashicorp/terraform-provider-google-beta/google-beta/services/filestore coverage: 63.6% of statements

[modular-magician]

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccFilestoreInstance_directoryServices

Tests analytics

Total tests: 19
Passed tests: 18
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• filestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccFilestoreInstance_directoryServices

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccFilestoreInstance_directoryServices [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Click here to see Test Coverage Metrics

• github.com/hashicorp/terraform-provider-google-beta/google-beta/services/filestore coverage: 63.6% of statements

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 323 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 72 insertions(+), 14 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 197 insertions(+))

[modular-magician]

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccFilestoreInstance_directoryServices

Tests analytics

Total tests: 19
Passed tests: 18
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• filestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccFilestoreInstance_directoryServices

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccFilestoreInstance_directoryServices [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Click here to see Test Coverage Metrics

• github.com/hashicorp/terraform-provider-google-beta/google-beta/services/filestore coverage: 63.6% of statements

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 321 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 72 insertions(+), 16 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 197 insertions(+))

[modular-magician]

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccFilestoreInstance_directoryServices

Tests analytics

Total tests: 19
Passed tests: 18
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• filestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccFilestoreInstance_directoryServices

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccFilestoreInstance_directoryServices [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 322 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 73 insertions(+), 17 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 197 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 322 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 73 insertions(+), 17 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 197 insertions(+))

[modular-magician]

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccFilestoreInstance_directoryServices

Tests analytics

Total tests: 19
Passed tests: 19
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• filestore

🟢 All tests passed!

View the build log

[modular-magician]

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccFilestoreInstance_directoryServices

Tests analytics

Total tests: 19
Passed tests: 19
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• filestore

🟢 All tests passed!

View the build log

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[github-actions]

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[NickElliot]

manual run Build #e3aa68c passed

LGTM!