-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add WireGroup Resource #14271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WireGroup Resource #14271
Conversation
c040016 to
8908706
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_wire_group" "primary" {
endpoints {
endpoint = # value needed
interconnects {
interconnect = # value needed
interconnect_name = # value needed
vlan_tags = # value needed
}
}
wire_properties {
fault_response = # value needed
}
wires {
wire_properties {
bandwidth_unmetered = # value needed
fault_response = # value needed
}
}
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_wire_group" "primary" {
endpoints {
endpoint = # value needed
interconnects {
interconnect = # value needed
interconnect_name = # value needed
vlan_tags = # value needed
}
}
wire_properties {
fault_response = # value needed
}
wires {
wire_properties {
bandwidth_unmetered = # value needed
fault_response = # value needed
}
}
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_wire_group" "primary" {
endpoints {
endpoint = # value needed
interconnects {
interconnect = # value needed
interconnect_name = # value needed
vlan_tags = # value needed
}
}
wire_properties {
fault_response = # value needed
}
wires {
wire_properties {
bandwidth_unmetered = # value needed
fault_response = # value needed
}
}
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_wire_group" "primary" {
endpoints {
endpoint = # value needed
interconnects {
interconnect = # value needed
interconnect_name = # value needed
vlan_tags = # value needed
}
}
wire_properties {
fault_response = # value needed
}
wires {
wire_properties {
bandwidth_unmetered = # value needed
fault_response = # value needed
}
}
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. |
Tests analyticsTotal tests: 1226 Click here to see the affected service packages
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
1 similar comment
Tests analyticsTotal tests: 1226 Click here to see the affected service packages
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Tests analyticsTotal tests: 1226 Click here to see the affected service packages
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Tests analyticsTotal tests: 1226 Click here to see the affected service packages
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_wire_group" "primary" {
endpoints {
endpoint = # value needed
interconnects {
interconnect = # value needed
interconnect_name = # value needed
vlan_tags = # value needed
}
}
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. |
Tests analyticsTotal tests: 1226 Click here to see the affected service packages
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Referencing to #14271 (comment), |
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
c2thorn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reassigning to original reviewer
|
@modular-magician reassign-reviewer @NickElliot |
NickElliot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add tests which use the endpoints fields?
|
Due to some reasons, acceptance test for the same couldn't be added, The manual testing is done though. Please refer #14271 (comment). |
NickElliot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you run some manual update tests too? need to verify if updating in place is fully supported
|
Manual Testing Update test: |
NickElliot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9f842e4
The WireGroup resource represents a group of redundant wires between interconnects in two different metros.
google_compute_wire_group
The WireGroup resource represents a group of redundant wires between interconnects in two different metros. Each WireGroup belongs to a CrossSiteNetwork. A wire group defines endpoints and the wires which exist between them.
~> Warning: This resource is in beta, and should be used with the terraform-provider-google-beta provider.
See Provider Versions for more details on beta resources.
To get more information about WireGroup, see:
Example Usage - Compute Wire Group Basic
Argument Reference
The following arguments are supported:
name-(Required)
Name of the resource. Provided by the client when the resource is created. The name must be
1-63 characters long, and comply with RFC1035. Specifically, the name must be 1-63 characters
long and match the regular expression
[a-z]([-a-z0-9]*[a-z0-9])?which means the firstcharacter must be a lowercase letter, and all following characters must be a dash,
lowercase letter, or digit, except the last character, which cannot be a dash.
cross_site_network-(Required)
Required cross site network to which wire group belongs.
description-(Optional)
An optional description of this resource. Provide this property when you create the resource.
endpoints-(Optional)
Endpoints grouped by location, each mapping to interconnect configurations.
Structure is documented below.
admin_enabled-(Optional)
Indicates whether the wire group is administratively enabled.
wire_group_properties-(Optional)
Properties specific to the wire group.
Structure is documented below.
wire_properties-(Optional)
Default properties for wires within the group.
Structure is documented below.
project- (Optional) The ID of the project in which the resource belongs.If it is not provided, the provider project is used.
The
endpointsblock supports:endpoint- (Required) The identifier for this object. Format specified above.interconnects-(Optional)
Structure is documented below.
The
interconnectsblock supports:interconnect_name- (Required) The identifier for this object. Format specified above.interconnect-(Optional)
vlan_tags-(Optional)
VLAN tags for the interconnect.
The
wire_group_propertiesblock supports:type-(Optional)
Type of wire group (enum).
WIRE: a single pseudowire over two Interconnect connections with no redundancy.
REDUNDANT: two pseudowires over four Interconnect connections, with two connections in one metro and two connections in another metro.
BOX_AND_CROSS: four pseudowires over four Interconnect connections, with two connections in one metro and two connections in another metro.
The
wire_propertiesblock supports:bandwidth_unmetered-(Optional)
The unmetered bandwidth setting.
fault_response-(Optional)
Response when a fault is detected in a pseudowire:
NONE: default.
DISABLE_PORT: set the port line protocol down when inline probes detect a fault. This setting is only permitted on port mode pseudowires.
Attributes Reference
In addition to the arguments listed above, the following computed attributes are exported:
id- an identifier for the resource with formatprojects/{{project}}/global/crossSiteNetworks/{{cross_site_network}}/wireGroups/{{name}}creation_timestamp-Creation timestamp in RFC3339 text format.
wires-The single/redundant wire(s) managed by the wire group.
Structure is documented below.
topology-Topology details for the wire group configuration.
Structure is documented below.
The
wiresblock contains:label-(Output)
endpoints-(Output)
'Wire endpoints are specific Interconnect connections.'
Structure is documented below.
wire_properties-(Output)
A nested object resource.
Structure is documented below.
admin_enabled-(Output)
The
endpointsblock contains:interconnect-(Output)
vlan_tag-(Output)
The
wire_propertiesblock contains:bandwidth_unmetered-(Optional)
fault_response-(Optional)
The
topologyblock contains:endpoints-(Output)
Structure is documented below.
The
endpointsblock contains:label-(Output)
city-(Output)
Timeouts
This resource provides the following
Timeouts configuration options:
create- Default is 20 minutes.update- Default is 20 minutes.delete- Default is 20 minutes.Import
WireGroup can be imported using any of these accepted formats:
projects/{{project}}/global/crossSiteNetworks/{{cross_site_network}}/wireGroups/{{name}}{{project}}/{{cross_site_network}}/{{name}}{{cross_site_network}}/{{name}}In Terraform v1.5.0 and later, use an
importblock to import WireGroup using one of the formats above. For example:When using the
terraform importcommand, WireGroup can be imported using one of the formats above. For example:User Project Overrides
This resource supports User Project Overrides.