Add new resource RegionCompositeHealthCheck to terraform-beta #14955

jkrish-c · 2025-08-22T18:00:06Z

Release Note Template for Downstream PRs (will be copied)

`google_compute_region_composite_health_checks` (beta)

modular-magician · 2025-08-22T18:15:05Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 655 insertions(+))
google-beta provider: Diff ( 19 files changed, 3942 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 371 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_health_aggregation_policy (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_health_aggregation_policy" "primary" {
  policy_type = # value needed
}

Missing service labels

The following new resources do not have corresponding service labels:

google_compute_region_composite_health_check
google_compute_region_health_aggregation_policy
google_compute_region_health_source

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Multiple resources added

This PR adds multiple new resources: google_compute_region_composite_health_check, google_compute_region_health_aggregation_policy, google_compute_region_health_source. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

modular-magician · 2025-08-22T18:44:39Z

Tests analytics

Total tests: 1270
Passed tests: 1181
Skipped tests: 83
Affected tests: 6

Click here to see the affected service packages

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-08-22T18:49:36Z

🔴 Tests failed during RECORDING mode:
TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update [Error message] [Debug log]
TestAccComputeRegionCompositeHealthCheck_computeRegionCompositeHealthCheckBasicExample [Error message] [Debug log]
TestAccComputeRegionCompositeHealthCheck_update [Error message] [Debug log]
TestAccComputeRegionHealthAggregationPolicy_update [Error message] [Debug log]
TestAccComputeRegionHealthSource_computeRegionHealthSourceBasicExample [Error message] [Debug log]
TestAccComputeRegionHealthSource_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-01-08T20:21:12Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 240 insertions(+))
google-beta provider: Diff ( 7 files changed, 1493 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 173 insertions(+))

modular-magician · 2026-01-08T20:24:33Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 240 insertions(+))
google-beta provider: Diff ( 7 files changed, 1493 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 173 insertions(+))

modular-magician · 2026-01-08T20:56:39Z

Tests analytics

Total tests: 1322
Passed tests: 1234
Skipped tests: 86
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-01-08T20:56:52Z

Tests analytics

Total tests: 1322
Passed tests: 1234
Skipped tests: 86
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-01-08T21:01:13Z

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionCompositeHealthCheck_computeRegionCompositeHealthCheckBasicExample [Debug log]
TestAccComputeRegionCompositeHealthCheck_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2026-01-08T21:01:22Z

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionCompositeHealthCheck_computeRegionCompositeHealthCheckBasicExample [Debug log]
TestAccComputeRegionCompositeHealthCheck_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2026-01-08T22:17:15Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 240 insertions(+))
google-beta provider: Diff ( 7 files changed, 1493 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 173 insertions(+))

modular-magician · 2026-01-08T22:35:44Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 240 insertions(+))
google-beta provider: Diff ( 7 files changed, 1493 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 173 insertions(+))

modular-magician · 2026-01-08T22:52:55Z

Tests analytics

Total tests: 1322
Passed tests: 1235
Skipped tests: 86
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-01-08T22:59:06Z

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2026-01-08T23:07:06Z

Tests analytics

Total tests: 1322
Passed tests: 1236
Skipped tests: 86
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

github-actions · 2026-01-09T17:26:15Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

mmv1/products/compute/RegionCompositeHealthCheck.yaml

mmv1/templates/terraform/examples/compute_region_composite_health_check_basic.tf.tmpl

...party/terraform/services/compute/resource_compute_region_composite_health_check_test.go.tmpl

Co-authored-by: Riley Karson <[email protected]>

modular-magician · 2026-01-09T18:10:40Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 240 insertions(+))
google-beta provider: Diff ( 7 files changed, 1507 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 173 insertions(+))

modular-magician · 2026-01-09T18:16:31Z

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccComputeRegionCompositeHealthCheck_computeRegionCompositeHealthCheckBasicExample
TestAccComputeRegionCompositeHealthCheck_update

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

modular-magician · 2026-01-09T18:26:57Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 240 insertions(+))
google-beta provider: Diff ( 7 files changed, 1507 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 173 insertions(+))

rileykarson

I forgot to add the new import when making suggestions!

...party/terraform/services/compute/resource_compute_region_composite_health_check_test.go.tmpl

modular-magician · 2026-01-09T18:31:52Z

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccComputeRegionCompositeHealthCheck_computeRegionCompositeHealthCheckBasicExample
TestAccComputeRegionCompositeHealthCheck_update

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

modular-magician · 2026-01-09T18:59:13Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 240 insertions(+))
google-beta provider: Diff ( 7 files changed, 1508 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 173 insertions(+))

modular-magician · 2026-01-09T19:01:39Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 240 insertions(+))
google-beta provider: Diff ( 7 files changed, 1508 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 173 insertions(+))

modular-magician · 2026-01-09T19:31:55Z

Tests analytics

Total tests: 1322
Passed tests: 1234
Skipped tests: 86
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-01-09T19:35:38Z

Tests analytics

Total tests: 1322
Passed tests: 1234
Skipped tests: 86
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-01-09T19:36:41Z

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionCompositeHealthCheck_computeRegionCompositeHealthCheckBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccComputeRegionCompositeHealthCheck_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-01-09T19:40:12Z

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionCompositeHealthCheck_computeRegionCompositeHealthCheckBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccComputeRegionCompositeHealthCheck_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

rileykarson · 2026-01-09T20:27:01Z

...party/terraform/services/compute/resource_compute_region_composite_health_check_test.go.tmpl

+				ImportStateVerify: true,
+			},
+			{
+				Config: testAccComputeRegionCompositeHealthCheck_basic(context),			


Ah- we run into a very annoying wart in Terraform, it attempts to do all deletes before updates during an apply. Since we haven't removed source2 from the composite check yet, deleting source2 fails. This can be corrected with lifecycle.create_before_destroy, but that introduces other problems (namely the one described by hashicorp/terraform-provider-google#25730)

Would you mind parametizing testAccComputeRegionCompositeHealthCheck_update to make health_sources an input? We'd then add a middle Config step here, where the current step uses the value "[google_compute_region_health_source.default.id, google_compute_region_health_source.default2.id]" and the new one would be "[google_compute_region_health_source.default.id]"

Add new resource RegionCompositeHealthCheck to terraform-beta provider.

d1ed700

jkrish-c force-pushed the chc branch from 872d644 to d1ed700 Compare January 8, 2026 20:09

Merge branch 'GoogleCloudPlatform:main' into chc

55354e7

modular-magician added the service/compute-health label Jan 8, 2026

jkrish-c changed the title ~~Chc~~ Add new resource RegionCompositeHealthCheck to terraform-beta Jan 8, 2026

adding newline for lint

78c752f

remove newline for lint

6e93e25

jkrish-c marked this pull request as ready for review January 9, 2026 17:25

github-actions bot requested a review from rileykarson January 9, 2026 17:26

rileykarson reviewed Jan 9, 2026

View reviewed changes

Apply suggestions from code review

f467aca

Co-authored-by: Riley Karson <[email protected]>

github-actions bot requested a review from rileykarson January 9, 2026 18:00

accepting reviewer suggestions

c732e8a

rileykarson reviewed Jan 9, 2026

View reviewed changes

...party/terraform/services/compute/resource_compute_region_composite_health_check_test.go.tmpl Show resolved Hide resolved

add upgrade guide to 7.0.0 branch (GoogleCloudPlatform#13790)

765069c

github-actions bot requested a review from rileykarson January 9, 2026 18:46

reorder imports

1cc9a71

rileykarson reviewed Jan 9, 2026

View reviewed changes

Add new resource RegionCompositeHealthCheck to terraform-beta #14955

Are you sure you want to change the base?

Add new resource RegionCompositeHealthCheck to terraform-beta #14955

Conversation

jkrish-c commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

modular-magician commented Aug 22, 2025

Diff report

Missing test report

Missing service labels

Multiple resources added

Uh oh!

modular-magician commented Aug 22, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Aug 22, 2025

Uh oh!

modular-magician commented Jan 8, 2026

Diff report

Uh oh!

modular-magician commented Jan 8, 2026

Diff report

Uh oh!

modular-magician commented Jan 8, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 8, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 8, 2026

Uh oh!

modular-magician commented Jan 8, 2026

Uh oh!

modular-magician commented Jan 8, 2026

Diff report

Uh oh!

modular-magician commented Jan 8, 2026

Diff report

Uh oh!

modular-magician commented Jan 8, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 8, 2026

Uh oh!

modular-magician commented Jan 8, 2026

Tests analytics

Uh oh!

github-actions bot commented Jan 9, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

modular-magician commented Jan 9, 2026

Diff report

Uh oh!

modular-magician commented Jan 9, 2026

Non-exercised tests

Tests analytics

Uh oh!

modular-magician commented Jan 9, 2026

Diff report

Uh oh!

rileykarson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

modular-magician commented Jan 9, 2026

Non-exercised tests

Tests analytics

Uh oh!

modular-magician commented Jan 9, 2026

Diff report

Uh oh!

modular-magician commented Jan 9, 2026

jkrish-c commented Aug 22, 2025 •

edited

Loading