Add Version Resource#15114
Conversation
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
I am struggling with what to do for the acceptance tests. I am unsure if update tests are appropriate since there is only one field to update. Trying to create an update test runs into an issue with the test trying to import resources since the ID is an unwritable field that is populated from the server. |
Adding an update test for a single field is valuable just to make sure we call the update method correctly. You can remove the import step of the test if it's causing problems due to server-generated names |
|
@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
| @@ -0,0 +1,65 @@ | |||
| # Copyright 2024 Google Inc. | |||
There was a problem hiding this comment.
| # Copyright 2024 Google Inc. | |
| # Copyright 2025 Google Inc. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 12 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 12 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
| @@ -0,0 +1,76 @@ | |||
| # Copyright 2024 Google Inc. | |||
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_dialogflow_version" "primary" {
version_id = # value needed
}
|
Tests analyticsTotal tests: 12 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_dialogflow_version" "primary" {
version_id = # value needed
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. |
Tests analyticsTotal tests: 13 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
See latest comments, especially about version_id |
What are the differences between the CICD step and running locally?? Like I posted before running the acceptance tests gets them passing on my machine. I followed the steps in the magic modules documentation and if possible I would like to iterate outside of the PR to save time. |
The tests are running and passing. version_id is a different issue and likely needs to be removed. The failing checks are not relevant to this. PR |
removing version_id
|
@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
| references: | ||
| guides: | ||
| 'Official Documentation': 'https://cloud.google.com/dialogflow/docs/' | ||
| api: 'https://cloud.google.com/dialogflow/docs/reference/rest/v2/projects/agent/versions' |
| type: String | ||
| description: | | ||
| The developer-provided description of this version. | ||
| required: false |
| The status of this version. | ||
| output: true | ||
| enum_values: | ||
| - 'VERSION_STATUS_UNSPECIFIED' |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. |
Tests analyticsTotal tests: 13 Click here to see the affected service packages
🟢 All tests passed! View the build log |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. |
Tests analyticsTotal tests: 13 Click here to see the affected service packages
🟢 All tests passed! View the build log |
4151101
Add support for Dialogflow Version.
Release Note Template for Downstream PRs (will be copied)