Skip to content

Add Version Resource#15114

Merged
slevenick merged 19 commits intoGoogleCloudPlatform:mainfrom
Spheny1:main
Nov 17, 2025
Merged

Add Version Resource#15114
slevenick merged 19 commits intoGoogleCloudPlatform:mainfrom
Spheny1:main

Conversation

@Spheny1
Copy link
Contributor

@Spheny1 Spheny1 commented Sep 11, 2025

Add support for Dialogflow Version.
Release Note Template for Downstream PRs (will be copied)

`google_dialogflow_version`

@github-actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from slevenick September 11, 2025 03:35
@Spheny1
Copy link
Contributor Author

Spheny1 commented Sep 11, 2025

I am struggling with what to do for the acceptance tests. I am unsure if update tests are appropriate since there is only one field to update. Trying to create an update test runs into an issue with the test trying to import resources since the ID is an unwritable field that is populated from the server.

@slevenick
Copy link
Contributor

I am struggling with what to do for the acceptance tests. I am unsure if update tests are appropriate since there is only one field to update. Trying to create an update test runs into an issue with the test trying to import resources since the ID is an unwritable field that is populated from the server.

Adding an update test for a single field is valuable just to make sure we call the update method correctly.

You can remove the import step of the test if it's causing problems due to server-generated names

@github-actions
Copy link

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@@ -0,0 +1,65 @@
# Copyright 2024 Google Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Copyright 2024 Google Inc.
# Copyright 2025 Google Inc.

@github-actions github-actions bot requested a review from slevenick September 16, 2025 14:02
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 760 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 760 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 71 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 104 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 12
Passed tests: 10
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • dialogflow

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDialogflowVersion_dialogflowVersionFullExample
  • TestAccDialogflowVersion_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDialogflowVersion_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccDialogflowVersion_dialogflowVersionFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@github-actions github-actions bot requested a review from slevenick September 17, 2025 14:10
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 770 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 770 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 71 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 109 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 12
Passed tests: 11
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • dialogflow

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDialogflowVersion_dialogflowVersionFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDialogflowVersion_dialogflowVersionFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@github-actions github-actions bot requested a review from slevenick September 23, 2025 07:56
@@ -0,0 +1,76 @@
# Copyright 2024 Google Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2025

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 847 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 847 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 71 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dialogflow_version (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dialogflow_version" "primary" {
  version_id = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 12
Passed tests: 11
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • dialogflow

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDialogflowVersion_dialogflowVersionFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 883 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 883 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 125 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dialogflow_version (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dialogflow_version" "primary" {
  version_id = # value needed
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_dialogflow_version

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 13
Passed tests: 12
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • dialogflow

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDialogflowVersion_dialogflowVersionFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDialogflowVersion_dialogflowVersionFullExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@slevenick
Copy link
Contributor

See latest comments, especially about version_id

@Spheny1
Copy link
Contributor Author

Spheny1 commented Nov 12, 2025

See latest comments, especially about version_id

What are the differences between the CICD step and running locally?? Like I posted before running the acceptance tests gets them passing on my machine. I followed the steps in the magic modules documentation and if possible I would like to iterate outside of the PR to save time.

@slevenick
Copy link
Contributor

See latest comments, especially about version_id

What are the differences between the CICD step and running locally?? Like I posted before running the acceptance tests gets them passing on my machine. I followed the steps in the magic modules documentation and if possible I would like to iterate outside of the PR to save time.

The tests are running and passing. version_id is a different issue and likely needs to be removed. The failing checks are not relevant to this. PR

removing version_id
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Nov 16, 2025
@github-actions
Copy link

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Nov 17, 2025
references:
guides:
'Official Documentation': 'https://cloud.google.com/dialogflow/docs/'
api: 'https://cloud.google.com/dialogflow/docs/reference/rest/v2/projects/agent/versions'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Page 404s

type: String
description: |
The developer-provided description of this version.
required: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs fix

The status of this version.
output: true
enum_values:
- 'VERSION_STATUS_UNSPECIFIED'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs fix

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Nov 17, 2025
@github-actions github-actions bot requested a review from slevenick November 17, 2025 19:05
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 872 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 872 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 125 insertions(+))

Missing service labels

The following new resources do not have corresponding service labels:

  • google_dialogflow_version

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 13
Passed tests: 13
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • dialogflow

🟢 All tests passed!

View the build log

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Nov 17, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 872 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 872 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 125 insertions(+))

Missing service labels

The following new resources do not have corresponding service labels:

  • google_dialogflow_version

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 13
Passed tests: 13
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • dialogflow

🟢 All tests passed!

View the build log

@slevenick slevenick added this pull request to the merge queue Nov 17, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 4151101 Nov 17, 2025
27 of 29 checks passed
bcreddy-gcp pushed a commit to bcreddy-gcp/magic-modules that referenced this pull request Nov 24, 2025
deliaqi pushed a commit to deliaqi/magic-modules that referenced this pull request Nov 26, 2025
JianweiQ pushed a commit to JianweiQ/magic-modules that referenced this pull request Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants