Fix Issue 24367: The provider hashicorp/google does not support resource type "google_project_service_identity"

[rohanchawla23]

Old test was causing errors, since google_project_service_identity is a beta resource, which wasn't taken into account. I fixed this issue by creating a separate test for testing the encryption_spec (privateca_capool_cmek) and reverting privateca_capool_all_fields to its previous version. The new test is now skipped, following the precedent set here

Fixes hashicorp/terraform-provider-google#24367

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 95 insertions(+), 21 deletions(-))
google-beta provider: Diff ( 2 files changed, 95 insertions(+), 21 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+), 19 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 95 insertions(+), 21 deletions(-))
google-beta provider: Diff ( 2 files changed, 95 insertions(+), 21 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+), 19 deletions(-))

[modular-magician]

Tests analytics

Total tests: 44
Passed tests: 35
Skipped tests: 8
Affected tests: 1

Click here to see the affected service packages

• privateca

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccPrivatecaCaPool_privatecaCapoolAllFieldsExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccPrivatecaCaPool_privatecaCapoolAllFieldsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 44
Passed tests: 35
Skipped tests: 8
Affected tests: 1

Click here to see the affected service packages

• privateca

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccPrivatecaCaPool_privatecaCapoolAllFieldsExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccPrivatecaCaPool_privatecaCapoolAllFieldsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 96 insertions(+), 20 deletions(-))
google-beta provider: Diff ( 2 files changed, 96 insertions(+), 20 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+), 18 deletions(-))

[modular-magician]

Tests analytics

Total tests: 44
Passed tests: 35
Skipped tests: 8
Affected tests: 1

Click here to see the affected service packages

• privateca

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccPrivatecaCaPool_privatecaCapoolAllFieldsExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccPrivatecaCaPool_privatecaCapoolAllFieldsExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[github-actions]

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[rileykarson]

@modular-magician reassign-reviewer

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 4 insertions(+), 142 deletions(-))
google-beta provider: Diff ( 2 files changed, 8 insertions(+), 7 deletions(-))

[modular-magician]

Tests analytics

Total tests: 44
Passed tests: 35
Skipped tests: 8
Affected tests: 1

Click here to see the affected service packages

• privateca

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccPrivatecaCaPool_privatecaCapoolAllFieldsExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccPrivatecaCaPool_privatecaCapoolAllFieldsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 6 insertions(+), 142 deletions(-))
google-beta provider: Diff ( 2 files changed, 12 insertions(+), 7 deletions(-))

[modular-magician]

Tests analytics

Total tests: 44
Passed tests: 35
Skipped tests: 8
Affected tests: 1

Click here to see the affected service packages

• privateca

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccPrivatecaCaPool_privatecaCapoolAllFieldsExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccPrivatecaCaPool_privatecaCapoolAllFieldsExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[rohanchawla23]

Unit test error seems to occur because it runs terraform init with a provider development override, which is known to cause errors.

Command: utils_test.go:133: running /usr/local/bin/terraform init -input=false:

Warning:

│ Warning: Provider development overrides are in effect
│ 
│ The following provider development overrides are set in the CLI
│ configuration:
│  - hashicorp/google-beta in /home/runner/go/bin
│ 
│ Skip terraform init when using provider development overrides. It is not
│ necessary and may error unexpectedly.

Assuming this error can be ignored, as I can't seem to be able to rerun the test.

[rileykarson]

LGTM, thanks!

Not sure why the test can't run locally- you shouldn't need overrides for acceptance tests, they build and run a provider directly from the codebase

[rileykarson]

TGC issue is unrelated