Skip to content

workbench: fix workbench instance full test failing due to version being populated after resource creation causing metadata count diff#15206

Merged
shuyama1 merged 3 commits intoGoogleCloudPlatform:mainfrom
bcreddy-gcp:wbi_full_failure
Sep 22, 2025
Merged

workbench: fix workbench instance full test failing due to version being populated after resource creation causing metadata count diff#15206
shuyama1 merged 3 commits intoGoogleCloudPlatform:mainfrom
bcreddy-gcp:wbi_full_failure

Conversation

@bcreddy-gcp
Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@github-actions github-actions bot requested a review from slevenick September 22, 2025 19:10
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 22, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@bcreddy-gcp bcreddy-gcp changed the title Wbi full failure workbench: fix workbench instance full test failing due to version being populated after resource creation causing metadata count diff Sep 22, 2025
@shuyama1
Copy link
Copy Markdown
Member

@modular-magician reassign-reviewer @shuyama1

@github-actions github-actions bot requested review from shuyama1 and removed request for slevenick September 22, 2025 19:17
@bcreddy-gcp
Copy link
Copy Markdown
Contributor Author

bcreddy-gcp commented Sep 22, 2025

Fixes: b/446536896, hashicorp/terraform-provider-google#24438

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 25
Passed tests: 24
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • workbench

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 25
Passed tests: 24
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • workbench

🟢 All tests passed!

View the build log

@shuyama1
Copy link
Copy Markdown
Member

shuyama1 commented Sep 22, 2025

Tests on TC

@shuyama1 shuyama1 added this pull request to the merge queue Sep 22, 2025
Merged via the queue into GoogleCloudPlatform:main with commit fbb2682 Sep 22, 2025
27 checks passed
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Sep 26, 2025
…ing populated after resource creation causing metadata count diff (GoogleCloudPlatform#15206)
jkrish-c pushed a commit to jkrish-c/magic-modules that referenced this pull request Oct 14, 2025
…ing populated after resource creation causing metadata count diff (GoogleCloudPlatform#15206)
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 20, 2025
…ing populated after resource creation causing metadata count diff (GoogleCloudPlatform#15206)
JianweiQ pushed a commit to JianweiQ/magic-modules that referenced this pull request Feb 20, 2026
…ing populated after resource creation causing metadata count diff (GoogleCloudPlatform#15206)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants