Skip to content

Add util function for waiting 1 min#15209

Closed
chengliwm wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
chengliwm:add-util
Closed

Add util function for waiting 1 min#15209
chengliwm wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
chengliwm:add-util

Conversation

@chengliwm
Copy link
Copy Markdown
Contributor

Fixes hashicorp/terraform-provider-google#24421

Add a util function for waiting 1 min. This PR is a preparation for adding new resources (KAJ Policy Config), which will require waiting 1 min after creation/update.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

@github-actions github-actions bot requested a review from hao-nan-li September 22, 2025 20:58
@github-actions
Copy link
Copy Markdown

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Copy link
Copy Markdown
Contributor

@hao-nan-li hao-nan-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this template is not used by any resource yet, do you plan to merge this first then use it in different PRs? I feel like this change could be included in other PRs so that this could be tested before it's merged.

@chengliwm
Copy link
Copy Markdown
Contributor Author

Looks like this template is not used by any resource yet, do you plan to merge this first then use it in different PRs? I feel like this change could be included in other PRs so that this could be tested before it's merged.

Yes, my plan was to merge this first and used in a different PR. I can put this util together with the resource that uses it.

@github-actions github-actions bot requested a review from hao-nan-li September 23, 2025 16:59
@chengliwm chengliwm closed this Sep 23, 2025
@chengliwm chengliwm deleted the add-util branch September 23, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new resources KajPolicyConfig to Cloud KMS

3 participants