Added new resource "LbEdgeExtension" by matheusaleixo-cit · Pull Request #15456 · GoogleCloudPlatform/magic-modules

matheusaleixo-cit · 2025-10-22T14:55:48Z

Adds new resource google_network_services_lb_edge_extension.

Release Note Template for Downstream PRs (will be copied)

`google_network_services_lb_edge_extension`

github-actions · 2025-11-11T21:10:04Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

melinath · 2025-11-12T19:45:07Z

/gcbrun

melinath

I've kicked off a test run in case there are failures. I looked through the code & it generally looks reasonable; just one change suggestion for the update tests.

...party/terraform/services/networkservices/resource_network_services_lb_edge_extension_test.go

modular-magician · 2025-11-12T20:03:38Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 2090 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 2090 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 332 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_services_lb_edge_extension (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_services_lb_edge_extension" "primary" {
  extension_chains {
    extensions {
      authority = # value needed
      timeout   = # value needed
    }
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

google_network_services_lb_edge_extension

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

modular-magician · 2025-11-12T20:08:18Z

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccNetworkServicesLbEdgeExtension_networkServicesLbEdgeExtensionBasicExample

Tests analytics

Total tests: 73
Passed tests: 67
Skipped tests: 4
Affected tests: 2

Click here to see the affected service packages

networkservices

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetworkServicesGateway_swpUpdate

TestAccNetworkServicesLbEdgeExtension_networkServicesLbEdgeExtensionBasicUpdate

Get to know how VCR tests work

modular-magician · 2025-11-12T20:17:27Z

🟢 Tests passed during RECORDING mode:
TestAccNetworkServicesLbEdgeExtension_networkServicesLbEdgeExtensionBasicUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccNetworkServicesGateway_swpUpdate [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

melinath · 2025-11-12T22:38:53Z

mmv1/products/networkservices/LbEdgeExtension.yaml

+      lb_edge_extension_name: 'elb-edge-ext'
+      wasm_plugin_name: 'elb-wasm-plugin-data'
+      repository_name: 'repository-standard'
+    skip_test: https://github.com/GoogleCloudPlatform/magic-modules/pull/12275#discussion_r2283175770


It looks like you found a way to set up a wasm_plugin in the update test - very cool! In that case, rather than generating a skipped test here, you can just exclude the example from test generation altogether.

Suggested change

skip_test: https://github.com/GoogleCloudPlatform/magic-modules/pull/12275#discussion_r2283175770

exclude_test: true

melinath

please also fix the missing tests.

- Removed extension fields authority and timeout;

matheusaleixo-cit · 2025-11-13T20:05:43Z

Hi, I removed the two extension fields authority and timeout since according to the API docs they are not supported for plugin extensions.

modular-magician · 2025-11-13T20:33:53Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1864 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1864 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 310 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_services_lb_edge_extension (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_services_lb_edge_extension" "primary" {
  description = # value needed
  extension_chains {
    extensions {
      fail_open        = # value needed
      forward_headers  = # value needed
      name             = # value needed
      service          = # value needed
      supported_events = # value needed
    }
    match_condition {
      cel_expression = # value needed
    }
    name = # value needed
  }
  forwarding_rules      = # value needed
  labels                = # value needed
  load_balancing_scheme = # value needed
  location              = # value needed
  name                  = # value needed
}

Missing service labels

The following new resources do not have corresponding service labels:

google_network_services_lb_edge_extension

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

modular-magician · 2025-11-13T20:38:26Z

Tests analytics

Total tests: 72
Passed tests: 68
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

networkservices

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetworkServicesGateway_swpUpdate

Get to know how VCR tests work

modular-magician · 2025-11-13T20:40:17Z

🔴 Tests failed during RECORDING mode:
TestAccNetworkServicesGateway_swpUpdate [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

melinath

Could you add the missing tests? These were previously in the (skipped) example so they weren't detected as "missing" (even though they were).

github-actions · 2025-11-19T09:44:15Z

@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

…-extensions

melinath

It looks like the tests aren't getting detected due to the use of fmt.Sprint. I'm actually not 100% sure whether switching to string concatenation will fix the problem, but fmt.Sprint isn't a common pattern / both args are strings, so I'd prefer to eliminate it regardless. If the tests still aren't detected I'll just verify that all fields are present manually.

P.S. Thanks for making sure updatable fields were being updated!

melinath · 2025-11-20T18:14:44Z

...party/terraform/services/networkservices/resource_network_services_lb_edge_extension_test.go

+}
+
+func testAccNetworkServicesLbEdgeExtension_networkServicesLbEdgeExtensionBasicCreate(context map[string]interface{}) string {
+	return fmt.Sprint(testAccNetworkServicesWasmPlugin_artifactRegistryRepositorySetup(context), acctest.Nprintf(`


Suggested change

return fmt.Sprint(testAccNetworkServicesWasmPlugin_artifactRegistryRepositorySetup(context), acctest.Nprintf(`

return testAccNetworkServicesWasmPlugin_artifactRegistryRepositorySetup(context) + acctest.Nprintf(`

melinath · 2025-11-20T18:15:06Z

...party/terraform/services/networkservices/resource_network_services_lb_edge_extension_test.go

+}
+
+func testAccNetworkServicesLbEdgeExtension_networkServicesLbEdgeExtensionBasicUpdate(context map[string]interface{}) string {
+	return fmt.Sprint(testAccNetworkServicesWasmPlugin_artifactRegistryRepositorySetup(context), acctest.Nprintf(`


Suggested change

return fmt.Sprint(testAccNetworkServicesWasmPlugin_artifactRegistryRepositorySetup(context), acctest.Nprintf(`

return testAccNetworkServicesWasmPlugin_artifactRegistryRepositorySetup(context) + acctest.Nprintf(`

melinath · 2025-11-20T18:15:21Z

...party/terraform/services/networkservices/resource_network_services_lb_edge_extension_test.go

+    }
+  }
+}
+`, context))


Suggested change

`, context))

`, context)

melinath · 2025-11-20T18:15:30Z

...party/terraform/services/networkservices/resource_network_services_lb_edge_extension_test.go

+    }
+  }
+}
+`, context))


Suggested change

`, context))

`, context)

modular-magician · 2025-11-21T17:36:05Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1864 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1864 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 310 insertions(+))

modular-magician · 2025-11-21T17:41:07Z

Tests analytics

Total tests: 76
Passed tests: 69
Skipped tests: 3
Affected tests: 4

Click here to see the affected service packages

networkservices

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetworkServicesGateway_swpUpdate

TestAccNetworkServicesLbEdgeExtension_networkServicesLbEdgeExtensionBasicUpdate

TestAccNetworkServicesServiceBinding_networkServicesServiceBindingBasicExample

TestAccNetworkServicesServiceBinding_update

Get to know how VCR tests work

modular-magician · 2025-11-21T17:48:27Z

🟢 Tests passed during RECORDING mode:
TestAccNetworkServicesLbEdgeExtension_networkServicesLbEdgeExtensionBasicUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccNetworkServicesGateway_swpUpdate [Error message] [Debug log]
TestAccNetworkServicesServiceBinding_networkServicesServiceBindingBasicExample [Error message] [Debug log]
TestAccNetworkServicesServiceBinding_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

melinath · 2025-11-24T23:15:04Z

sweet, looks like that fixed the test detection

melinath

Overall this looks good. I have a few nits but I'll just apply those & queue this for merge if everything's good.

melinath · 2025-11-24T23:26:48Z

mmv1/products/networkservices/LbEdgeExtension.yaml

+              description: |
+                A Common Expression Language (CEL) expression that is used to match requests for which the extension chain is executed.
+              required: true
+        - name: 'extensions'


It looks like not all the subfields here are supported; that's not a blocker for the initial implementation but wanted to flag it for potential follow-up: https://docs.cloud.google.com/service-extensions/docs/reference/rest/v1/ExtensionChain#extension Possibly they're not valid for this type of object though!

mmv1/products/networkservices/LbEdgeExtension.yaml

melinath · 2025-11-24T23:34:23Z

mmv1/products/networkservices/LbEdgeExtension.yaml

+    base_url: '{{op_id}}'
+  result:
+    resource_inside_response: false
+custom_code:


nit

Suggested change

custom_code:

melinath · 2025-11-24T23:34:34Z

mmv1/products/networkservices/LbEdgeExtension.yaml

+  guides:
+    'Configure a edge extension': 'https://cloud.google.com/service-extensions/docs/configure-edge-extensions'
+  api: 'https://cloud.google.com/service-extensions/docs/reference/rest/v1beta1/projects.locations.lbEdgeExtensions'
+docs:


nit

Suggested change

docs:

modular-magician · 2025-11-24T23:52:25Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1864 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1864 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 310 insertions(+))

modular-magician · 2025-11-24T23:58:11Z

Tests analytics

Total tests: 78
Passed tests: 65
Skipped tests: 3
Affected tests: 10

Click here to see the affected service packages

networkservices

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetworkServicesGateway_minimalSwp

TestAccNetworkServicesGateway_multipleSwpGatewaysDifferentNetwork

TestAccNetworkServicesGateway_multipleSwpGatewaysDifferentSubnetwork

TestAccNetworkServicesGateway_networkServicesGatewayMultipleSwpSameNetworkExample

TestAccNetworkServicesGateway_networkServicesGatewaySecureWebProxyExample

TestAccNetworkServicesGateway_networkServicesGatewaySecureWebProxyWithoutAddresses

TestAccNetworkServicesGateway_swpAsNextHop

TestAccNetworkServicesGateway_swpUpdate

TestAccNetworkServicesServiceBinding_networkServicesServiceBindingBasicExample

TestAccNetworkServicesServiceBinding_update

Get to know how VCR tests work

modular-magician · 2025-11-25T00:02:16Z

🟢 Tests passed during RECORDING mode:
TestAccNetworkServicesGateway_minimalSwp [Debug log]
TestAccNetworkServicesGateway_multipleSwpGatewaysDifferentNetwork [Debug log]
TestAccNetworkServicesGateway_multipleSwpGatewaysDifferentSubnetwork [Debug log]
TestAccNetworkServicesGateway_networkServicesGatewayMultipleSwpSameNetworkExample [Debug log]
TestAccNetworkServicesGateway_networkServicesGatewaySecureWebProxyExample [Debug log]
TestAccNetworkServicesGateway_networkServicesGatewaySecureWebProxyWithoutAddresses [Debug log]
TestAccNetworkServicesGateway_swpAsNextHop [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccNetworkServicesGateway_swpUpdate [Error message] [Debug log]
TestAccNetworkServicesServiceBinding_networkServicesServiceBindingBasicExample [Error message] [Debug log]
TestAccNetworkServicesServiceBinding_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

melinath

LGTM - failing tests are unrelated

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

- Added new resource LbEdgeExtension and related tests;

ead0a0a

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Oct 22, 2025

- Removed min_version tag from LbEdgeExtension;

24b1f8c

matheusaleixo-cit marked this pull request as ready for review November 11, 2025 21:09

github-actions bot requested a review from melinath November 11, 2025 21:10

melinath requested changes Nov 12, 2025

View reviewed changes

...party/terraform/services/networkservices/resource_network_services_lb_edge_extension_test.go Show resolved Hide resolved

...party/terraform/services/networkservices/resource_network_services_lb_edge_extension_test.go Show resolved Hide resolved

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Nov 12, 2025

- Added update ConfigPlanChecks to LbEdgeExtensionBasicUpdate test;

0052daa

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Nov 12, 2025

github-actions bot requested a review from melinath November 12, 2025 20:57

melinath requested changes Nov 12, 2025

View reviewed changes

- Updated lb_edge_extension_basic to not generate tests;

e5edcd3

- Removed extension fields authority and timeout;

github-actions bot requested a review from melinath November 13, 2025 19:54

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Nov 13, 2025

melinath requested changes Nov 13, 2025

View reviewed changes

melinath mentioned this pull request Nov 13, 2025

Don't count skipped tests towards field test coverage hashicorp/terraform-provider-google#25141

Open

- WiP Small test changes;

3cbe60c

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Nov 14, 2025

github-actions bot requested a review from melinath November 14, 2025 22:34

Merge branch 'main' into add-new-resource-for-networkservices-lb-edge…

4df70b6

…-extensions

melinath requested changes Nov 20, 2025

View reviewed changes

- Removed use of fmt.Sprint in test LbEdgeExtensionBasicUpdate;

72fd217

github-actions bot requested a review from melinath November 21, 2025 14:36

modular-magician added service/networkservices-service-extensions and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Nov 21, 2025

melinath requested changes Nov 24, 2025

View reviewed changes

Apply suggestions from code review

8d6928d

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Nov 24, 2025

github-actions bot requested a review from melinath November 24, 2025 23:37

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Nov 24, 2025

melinath approved these changes Nov 25, 2025

View reviewed changes

melinath added this pull request to the merge queue Nov 25, 2025

Merged via the queue into GoogleCloudPlatform:main with commit ce790e6 Nov 25, 2025
30 of 31 checks passed

deliaqi pushed a commit to deliaqi/magic-modules that referenced this pull request Nov 26, 2025

Added new resource "LbEdgeExtension" (GoogleCloudPlatform#15456)

828a822

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

vkanishk15 pushed a commit to vkanishk15/magic-modules that referenced this pull request Dec 11, 2025

Added new resource "LbEdgeExtension" (GoogleCloudPlatform#15456)

e84dd46

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

matheusaleixo-cit deleted the add-new-resource-for-networkservices-lb-edge-extensions branch December 11, 2025 17:35

JianweiQ pushed a commit to JianweiQ/magic-modules that referenced this pull request Feb 20, 2026

Added new resource "LbEdgeExtension" (GoogleCloudPlatform#15456)

ded9208

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

	skip_test: https://github.com/GoogleCloudPlatform/magic-modules/pull/12275#discussion_r2283175770
	exclude_test: true

	return fmt.Sprint(testAccNetworkServicesWasmPlugin_artifactRegistryRepositorySetup(context), acctest.Nprintf(`
	return testAccNetworkServicesWasmPlugin_artifactRegistryRepositorySetup(context) + acctest.Nprintf(`

Conversation

matheusaleixo-cit commented Oct 22, 2025

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

melinath commented Nov 12, 2025

Uh oh!

melinath left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

modular-magician commented Nov 12, 2025

Diff report

Missing test report

Missing service labels

Uh oh!

modular-magician commented Nov 12, 2025

Non-exercised tests

Tests analytics

Action taken

Uh oh!

modular-magician commented Nov 12, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

melinath left a comment

Choose a reason for hiding this comment

Uh oh!

matheusaleixo-cit commented Nov 13, 2025

Uh oh!

modular-magician commented Nov 13, 2025

Diff report

Missing test report

Missing service labels

Uh oh!

modular-magician commented Nov 13, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Nov 13, 2025

Uh oh!

melinath left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 19, 2025

Uh oh!

melinath left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

modular-magician commented Nov 21, 2025

Diff report

Uh oh!

modular-magician commented Nov 21, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Nov 21, 2025

Uh oh!

melinath commented Nov 24, 2025

Uh oh!

melinath left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment