Skip to content

tgc-revival: support SecretManagerSecret#15473

Merged
zli82016 merged 2 commits intoGoogleCloudPlatform:mainfrom
zli82016:tgc-secret
Oct 23, 2025
Merged

tgc-revival: support SecretManagerSecret#15473
zli82016 merged 2 commits intoGoogleCloudPlatform:mainfrom
zli82016:tgc-secret

Conversation

@zli82016
Copy link
Copy Markdown
Member

@zli82016 zli82016 commented Oct 22, 2025

  1. Ignore fields with ignore_read: true
  2. Modify the logic to identify IdentityParam extracted from the CAI asset name for the resources with the same CAI asset type.
    The CAI asset type secretmanager.googleapis.com/Secret is shared by two resources: google_secret_manager_regional_secret and google_secret_manager_secret
    1. The CAI asset name for google_secret_manager_regional_secret is //secretmanager.googleapis.com/projects/653407317329/locations/us-central1/secrets/tf-test-tf-reg-secretgbh9egbmva. The extracted IdentityParam is locations
    2. The CAI asset name for google_secret_manager_secret is //secretmanager.googleapis.com/projects/653407317329/secrets/tf-test-tf-reg-secretgbh9egbmva. The extracted IdentityParam is ""

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 12 files changed, 1994 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 30 files changed, 2155 insertions(+), 1 deletion(-))

@zli82016 zli82016 marked this pull request as ready for review October 22, 2025 23:57
@zli82016 zli82016 requested a review from trodge October 22, 2025 23:59
@zli82016 zli82016 changed the title tgc-revival: supporte SecretManagerSecret tgc-revival: support SecretManagerSecret Oct 23, 2025
@zli82016 zli82016 added this pull request to the merge queue Oct 23, 2025
Merged via the queue into GoogleCloudPlatform:main with commit fe71c31 Oct 23, 2025
30 checks passed
@zli82016 zli82016 deleted the tgc-secret branch October 23, 2025 21:43
jkrish-c pushed a commit to jkrish-c/magic-modules that referenced this pull request Oct 24, 2025
akerekes pushed a commit to akerekes/magic-modules that referenced this pull request Oct 29, 2025
bcreddy-gcp pushed a commit to bcreddy-gcp/magic-modules that referenced this pull request Nov 24, 2025
JianweiQ pushed a commit to JianweiQ/magic-modules that referenced this pull request Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants